Cloud-J in GEOS-Chem Classic #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizziel
force-pushed
the
feature/cloud-j
branch
from
2eda9f7 to
e08812a
Compare
lizziel
force-pushed
the
feature/cloud-j
branch
from
9fb3e48 to
3e12bec
Compare
lizziel
changed the title
yantosca
added
topic: Build
|
Thanks @yantosca! I just merged in dev/14.3.0 and updated the changelog. |
yantosca
force-pushed
the
feature/cloud-j
branch
from
7fabdce to
1540e75
Compare
lizziel
force-pushed
the
feature/cloud-j
branch
from
1540e75 to
c5afa01
Compare
CLOUDJ is now a compile-time option in GEOS-Chem Classic. Note that Cloud-J itself is not yet used in GEOS-Chem with this update. Signed-off-by: Lizzie Lundgren <[email protected]>
Submodule src/Cloud-J 766472c..4d612ea:
> Update comments in cld_sub_mod for clarity
> Remove unused inputs to ICA_* subroutines called in Cloud_JX
> Fix bug in Cloud-J standalone for computing ice water path input
to Cloud-J
> Minor updates, including fixing write statement format to fit
# GC jvalues
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
> Merge pull request #4 from jimmielin/hplin/fix_decl_ifort > Updates for using MAPL in Cloud-J > Include compile definition for MODEL_GEOSCHEM when building in GCHP Signed-off-by: Lizzie Lundgren <[email protected]>
> Remove unused common variables JXL_, JXL1_, and JXL2_ > Make number of CTM levels set by the calling program during initialization Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]> # Conflicts: # CHANGELOG.md
lizziel
force-pushed
the
feature/cloud-j
branch
from
c5afa01 to
a80df2e
Compare
msulprizio
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This update adds the Cloud-J photolysis library as a submodule with GC-Classic. It is stored alongside GEOS-Chem and HEMCO in the
srcfolder. This PR should be merged with geoschem/geos-chem#1522.Expected changes
See geoschem/geos-chem#1522 for changes expected in GEOS-Chem when using Cloud-J to compute J-values.
Reference(s)
Prather, M. J.: Photolysis rates in correlated overlapping cloud fields: Cloud-J 7.3c, Geosci. Model Dev., 8, 2587–2595, https://doi.org/10.5194/gmd-8-2587-2015, 2015.
Related Github Issue(s)
geoschem/geos-chem#1522