Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud-J in GEOS-Chem Classic #27

Merged
merged 7 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@
[submodule "docs/source/geos-chem-shared-docs"]
path = docs/source/geos-chem-shared-docs
url = https://github.com/geoschem/geos-chem-shared-docs.git
[submodule "src/Cloud-J"]
path = src/Cloud-J
url = https://github.com/geoschem/Cloud-J.git
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
### Changed
- Updated GEOS-Chem submodule to 14.3.0

### Added
- Added Cloud-J submodule which is the new default photolysis package used in GEOS-Chem
- Added compile option FASTJX to use legacy FAST-JX photolysis in GEOS-Chem instead of Cloud-J

## [14.2.3] - 2023-12-01
### Added
- Script `.release/changeVersionNumbers.sh` to change version numbers before a new GEOS-Chem Classic release
Expand Down
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ endif()
set(GCCLASSIC_WRAPPER TRUE)
set(GC_EXTERNAL_CONFIG FALSE)
set(HEMCO_EXTERNAL_CONFIG TRUE)
set(CLOUDJ_EXTERNAL_CONFIG TRUE)

#-----------------------------------------------------------------------------
# Add the directory with source code
Expand Down
15 changes: 15 additions & 0 deletions CMakeScripts/GC-ConfigureClassic.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,20 @@ function(configureGCClassic)
)
endif()

#-------------------------------------------------------------------------
# Use Fast-JX rather than Cloud-J?
#-------------------------------------------------------------------------

set(FASTJX OFF CACHE BOOL
"Switch to use legacy FAST-JX in GEOS-Chem"
)
gc_pretty_print(VARIABLE FASTJX IS_BOOLEAN)
if(${FASTJX})
target_compile_definitions(GEOSChemBuildProperties
INTERFACE FASTJX
)
endif()

#-------------------------------------------------------------------------
# Export the following variables to GEOS-Chem directory's scope
#-------------------------------------------------------------------------
Expand All @@ -214,6 +228,7 @@ function(configureGCClassic)
set(GTMM ${GTMM} PARENT_SCOPE)
set(LUO_WETDEP ${LUO_WETDEP} PARENT_SCOPE)
set(SANITIZE ${SANITIZE} PARENT_SCOPE)
set(FASTJX ${FASTJX} PARENT_SCOPE)

#-------------------------------------------------------------------------
# Export information about Git status
Expand Down
1 change: 1 addition & 0 deletions CMakeScripts/summarize_build
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ print_item_highlight RRTMG $(scrape_cache RRTMG)
print_item_highlight GTMM $(scrape_cache GTMM)
print_item_highlight HCOSA $(scrape_cache HCOSA)
print_item_highlight LUO_WETDEP $(scrape_cache LUO_WETDEP)
print_item_highlight FASTJX $(scrape_cache FASTJX)
echo ""

# grep --color "GEOSChem_Fortran_FLAGS_[A-Z_]*${COMPILER_ID}" $CACHEFILE
3 changes: 2 additions & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# src/CMakeLists.txt

#-----------------------------------------------------------------------------
# Tell CMake to look for code in HEMCO and GEOS-Chem directory trees
# Tell CMake to look for code in HEMCO, Cloud-J and GEOS-Chem directory trees
#-----------------------------------------------------------------------------
add_subdirectory(HEMCO EXCLUDE_FROM_ALL)
target_compile_definitions(HEMCOBuildProperties
Expand All @@ -11,6 +11,7 @@ target_compile_definitions(HEMCOBuildProperties
$<$<STREQUAL:${TOMAS_BINS},40>:TOMAS40>
""
)
add_subdirectory(Cloud-J EXCLUDE_FROM_ALL)
add_subdirectory(GEOS-Chem EXCLUDE_FROM_ALL)

#-----------------------------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions src/Cloud-J
Submodule Cloud-J added at a54689