Conversation
hearnadam
commented
Aug 17, 2025
| import scala.scalanative.unsafe.* | ||
|
|
||
| /** Internal global dispatcher to avoid capturing local state in C callbacks. */ | ||
| private object NativeSignalDispatch: |
Collaborator
Author
There was a problem hiding this comment.
This is to get around CFuncPtr.fromScalaFunction introducing undefined behavior when capturing lambdas. Not sure about the correctness.
ahoy-jon
approved these changes
Sep 7, 2025
Collaborator
ahoy-jon
left a comment
ahoy-jon
left a comment
There was a problem hiding this comment.
Should just be tested with a snapshot build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Native binaries currently don't respect signal interrupts.
/fixes #1240
Solution
Register native signal handlers.
Notes
I didn't find a good way to test this. Assuming it gets merged, we can use the snapshots to build a test app.