-
Notifications
You must be signed in to change notification settings - Fork 90
add: OsSignal for scala-native #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hearnadam
wants to merge
6
commits into
main
Choose a base branch
from
os-signal-native
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5c03198
add: OsSignal for scala-native
hearnadam a82ac11
Merge branch 'main' into os-signal-native
hearnadam 57ecb0c
Merge branch 'main' into os-signal-native
hearnadam 693d361
Merge branch 'main' into os-signal-native
fwbrasil d4e876b
Merge branch 'main' into os-signal-native
fwbrasil 547c9a1
Merge branch 'main' into os-signal-native
hearnadam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
34 changes: 34 additions & 0 deletions
34
kyo-core/native/src/main/scala/kyo/internal/OSSignalPlatformSpecific.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package kyo.internal | ||
|
|
||
| import OsSignal.Handler | ||
| import scala.scalanative.posix.signal as posix | ||
| import scala.scalanative.unsafe.* | ||
|
|
||
| /** Internal global dispatcher to avoid capturing local state in C callbacks. */ | ||
| private object NativeSignalDispatch: | ||
| private val registry = scala.collection.mutable.HashMap.empty[Int, () => Unit] | ||
|
|
||
| val cHandler: CFuncPtr1[CInt, Unit] = CFuncPtr1.fromScalaFunction { (sig: CInt) => | ||
| val cb = registry.synchronized { registry.get(sig) } | ||
| cb.foreach(_.apply()) | ||
| } | ||
|
|
||
| def install(signum: CInt, cb: () => Unit): Unit = | ||
| registry.synchronized { registry.update(signum, cb) } | ||
| end NativeSignalDispatch | ||
|
|
||
| /** Native-specific implementation using POSIX signals via Scala Native. */ | ||
| private[internal] class OsSignalPlatformSpecific: | ||
| val handle: Handler = new Handler: | ||
| private def signum(signal: String): CInt = | ||
| signal match | ||
| case "INT" => posix.SIGINT | ||
| case "TERM" => posix.SIGTERM | ||
| case "HUP" => posix.SIGHUP | ||
|
|
||
| override def apply(signalName: String, handler: () => Unit): Unit = | ||
| val num = signum(signalName) | ||
| NativeSignalDispatch.install(num, handler) | ||
| val _ = posix.signal(num, NativeSignalDispatch.cHandler) | ||
| end apply | ||
| end OsSignalPlatformSpecific | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to get around
CFuncPtr.fromScalaFunctionintroducing undefined behavior when capturing lambdas. Not sure about the correctness.