Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hooks for session replay #4974

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philprime
Copy link
Contributor

@philprime philprime commented Mar 12, 2025

📜 Description

These are two hooks that were side-effects while working on #4940

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- add hooks for session replay ([#4974](https://github.com/getsentry/sentry-cocoa/pull/4974))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 89f1233

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.433%. Comparing base (b31ebf8) to head (89f1233).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4974       +/-   ##
=============================================
- Coverage   92.436%   92.433%   -0.004%     
=============================================
  Files          669       669               
  Lines        79226     79231        +5     
  Branches     28644     28649        +5     
=============================================
+ Hits         73234     73236        +2     
- Misses        5895      5899        +4     
+ Partials        97        96        -1     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySessionReplayIntegration.m 88.662% <100.000%> (+0.051%) ⬆️
...tegrations/SessionReplay/SentryReplayOptions.swift 95.774% <ø> (ø)
...ift/Tools/ViewCapture/SentryViewPhotographer.swift 74.468% <100.000%> (+1.134%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31ebf8...89f1233. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.67 ms 1255.54 ms 22.87 ms
Size 22.30 KiB 832.28 KiB 809.97 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f05aa59 1211.31 ms 1249.73 ms 38.42 ms
b0e218b 1218.14 ms 1230.33 ms 12.19 ms
db533ee 1228.96 ms 1248.23 ms 19.28 ms
2af280d 1226.46 ms 1229.81 ms 3.35 ms
db31083 1252.52 ms 1266.65 ms 14.13 ms
16c38a2 1228.38 ms 1245.70 ms 17.32 ms
cf724da 1243.14 ms 1261.44 ms 18.30 ms
c0c1496 1201.19 ms 1228.36 ms 27.17 ms
8fd8904 1221.69 ms 1239.66 ms 17.97 ms
6bc5ae5 1207.23 ms 1216.66 ms 9.43 ms

App size

Revision Plain With Sentry Diff
f05aa59 22.30 KiB 749.84 KiB 727.54 KiB
b0e218b 21.58 KiB 638.28 KiB 616.70 KiB
db533ee 21.58 KiB 547.02 KiB 525.44 KiB
2af280d 20.76 KiB 435.22 KiB 414.46 KiB
db31083 22.85 KiB 407.62 KiB 384.77 KiB
16c38a2 21.90 KiB 726.19 KiB 704.29 KiB
cf724da 20.76 KiB 430.52 KiB 409.76 KiB
c0c1496 22.85 KiB 407.45 KiB 384.60 KiB
8fd8904 21.58 KiB 656.60 KiB 635.02 KiB
6bc5ae5 20.76 KiB 401.39 KiB 380.63 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant