ref: type KSCrash installer monitors - #8792
Merged
NinjaLikesCheez merged 1 commit intoAug 13, 2026
Merged
Conversation
NinjaLikesCheez
requested review from
itaybre,
noahsmartin,
philipphofmann and
philprime
as code owners
August 12, 2026 13:54
NinjaLikesCheez
added
the
run-full-ci
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df67624 | 1225.12 ms | 1259.90 ms | 34.78 ms |
| 6e35062 | 1232.19 ms | 1262.91 ms | 30.73 ms |
| 220d7ef | 1238.77 ms | 1267.42 ms | 28.65 ms |
| 4b5a1d7 | 1235.27 ms | 1264.49 ms | 29.22 ms |
| 9319185 | 1223.24 ms | 1249.98 ms | 26.73 ms |
| d0b52d1 | 1227.31 ms | 1258.32 ms | 31.01 ms |
| b6b0d1d | 1236.69 ms | 1270.22 ms | 33.52 ms |
| 5b1c31e | 1221.35 ms | 1246.14 ms | 24.79 ms |
| 9787f05 | 1233.67 ms | 1269.00 ms | 35.33 ms |
| 29d1b7f | 1220.58 ms | 1254.14 ms | 33.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df67624 | 24.14 KiB | 1.14 MiB | 1.12 MiB |
| 6e35062 | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| 220d7ef | 24.14 KiB | 1.17 MiB | 1.14 MiB |
| 4b5a1d7 | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| 9319185 | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| d0b52d1 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| b6b0d1d | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| 5b1c31e | 24.14 KiB | 1.24 MiB | 1.22 MiB |
| 9787f05 | 24.14 KiB | 1.18 MiB | 1.15 MiB |
| 29d1b7f | 24.14 KiB | 1.26 MiB | 1.23 MiB |
NinjaLikesCheez
force-pushed
the
feat/use-kscrash-api-restored
branch
from
August 13, 2026 06:37
9dfde85 to
3cf4397
Compare
📲 Install BuildsiOS
|
NinjaLikesCheez
force-pushed
the
feat/use-kscrash-api-restored
branch
from
August 13, 2026 08:30
3cf4397 to
e5c6995
Compare
NinjaLikesCheez
force-pushed
the
feat/use-kscrash-api-restored
branch
from
August 13, 2026 11:04
e5c6995 to
cbb0451
Compare
NinjaLikesCheez
force-pushed
the
feat/use-kscrash-api-restored
branch
from
August 13, 2026 11:11
cbb0451 to
d100e61
Compare
Use KSCrash's MonitorType through the installer interface instead of passing an untyped UInt mask. This removes the raw-value conversion at configuration and keeps the integration and its test mock type-safe.
NinjaLikesCheez
force-pushed
the
feat/use-kscrash-api-restored
branch
from
August 13, 2026 11:32
d100e61 to
53ae414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for incorrectly auto-merged #8787.
Restores the intended top layer of the KSCrash V10 stack.
#skip-changelog