Skip to content

ref: type KSCrash installer monitors #8792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NinjaLikesCheez merged 1 commit into from
Aug 13, 2026
+8 −7
Merged

ref: type KSCrash installer monitors #8792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/Swift/Integrations/KSCrash/SentryKSCrash+Installer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ extension SentryKSCrash {
/// - Throws: Any error from `KSCrash.installWithConfiguration(_:error:)`.
func install(
installPath: String,
monitors: UInt,
monitors: MonitorType,
enableMemoryIntrospection: Bool,
enableSwapCxaThrow: Bool
) throws
Expand Down Expand Up @@ -53,13 +53,13 @@ extension SentryKSCrash {

func install(
installPath: String,
monitors: UInt,
monitors: MonitorType,
enableMemoryIntrospection: Bool,
enableSwapCxaThrow: Bool
) throws {
let config = KSCrashConfiguration()
config.installPath = installPath
config.monitors = MonitorType(rawValue: monitors)
config.monitors = monitors
config.enableMemoryIntrospection = enableMemoryIntrospection
config.enableSwapCxaThrow = enableSwapCxaThrow
config.reportStoreConfiguration.reportCleanupPolicy = .onSuccess
Expand Down
4 changes: 2 additions & 2 deletions Sources/Swift/Integrations/KSCrash/SentryKSCrash+Integration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ extension SentryKSCrash {
/// Mach exceptions, signals, C++ exceptions, and NSExceptions.
/// KSCrash unconditionally adds its required infrastructure monitors on top of
/// the crash detectors passed here.
static let productionSafeMonitors: UInt = MonitorType([
static let productionSafeMonitors: MonitorType = [
.machException,
.signal,
.cppException,
.nsException
]).rawValue
]

final class Integration<Dependencies: DependencyProvider>: NSObject, SwiftIntegration {
private weak var options: Options?
Expand Down
5 changes: 3 additions & 2 deletions Tests/SentryTests/Integrations/KSCrash/MockKSCrashInstaller.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#if SDK_V10
@_spi(Private) import SentryTestUtils
@_spi(Private) @testable import Sentry
internal import KSCrashRecording

final class MockKSCrashDependencies: SentryKSCrash.DependencyProvider {
typealias Installing = MockKSCrashInstaller
Expand Down Expand Up @@ -32,7 +33,7 @@ final class MockKSCrashInstaller: SentryKSCrash.Installing {
public var installCalls: [
(
installPath: String,
monitors: UInt,
monitors: MonitorType,
enableMemoryIntrospection: Bool,
enableSwapCxaThrow: Bool
)
Expand All @@ -52,7 +53,7 @@ final class MockKSCrashInstaller: SentryKSCrash.Installing {

public func install(
installPath: String,
monitors: UInt,
monitors: MonitorType,
enableMemoryIntrospection: Bool,
enableSwapCxaThrow: Bool
) throws {
Expand Down
Loading