Ref(android-distribution): Remove main_binary_identifier parameter (EME-391) #4773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runningcode
requested review from
adinauer,
romtsn,
stefanosiano,
markushi and
lcian
as code owners
runningcode
commented
Oct 1, 2025
|
|
||
| /** Parameters for checking updates. */ | ||
| data class UpdateCheckParams( | ||
| val mainBinaryIdentifier: String, |
There was a problem hiding this comment.
I decided to just completely remove this field assuming we will never use it on android
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d217708 | 411.22 ms | 430.86 ms | 19.63 ms |
| 7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
| 14ff5ee | 419.75 ms | 495.73 ms | 75.98 ms |
| b3d8889 | 371.84 ms | 447.49 ms | 75.65 ms |
| b750b96 | 421.25 ms | 444.09 ms | 22.84 ms |
| c8125f3 | 397.65 ms | 485.14 ms | 87.49 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| d217708 | 355.34 ms | 381.39 ms | 26.05 ms |
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| 14ff5ee | 1.58 MiB | 2.10 MiB | 535.08 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
…ME-391) Removes the redundant main_binary_identifier parameter from the Build Distribution API calls, as it was always set to the same value as app_id. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
runningcode
force-pushed
the
no/remove-main-binary-identifier
branch
from
0275234 to
7eb31e4
Compare
romtsn
pushed a commit
that referenced
this pull request
Oct 7, 2025
…ME-391) (#4773) Removes the redundant main_binary_identifier parameter from the Build Distribution API calls, as it was always set to the same value as app_id. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the redundant
main_binary_identifierparameter from the Build Distribution feature. This parameter was always set to the same value asapp_id, making it redundant.Changes
mainBinaryIdentifierfield fromUpdateCheckParamsdata classmain_binary_identifierquery parameter from API URL constructionDistributionIntegrationto no longer pass the redundant parameter#skip-changelog
🤖 Generated with Claude Code