Skip to content

Ref(android-distribution): Remove main_binary_identifier parameter (EME-391) #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Ref(android-distribution): Remove main_binary_identifier parameter (EME-391) #4773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...droid-distribution/src/main/java/io/sentry/android/distribution/DistributionHttpClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ internal class DistributionHttpClient(private val options: SentryOptions) {

/** Parameters for checking updates. */
data class UpdateCheckParams(
val mainBinaryIdentifier: String,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to just completely remove this field assuming we will never use it on android

val appId: String,
val platform: String = "android",
val versionCode: Long,
Expand Down Expand Up @@ -53,8 +52,7 @@ internal class DistributionHttpClient(private val options: SentryOptions) {
append(
"/api/0/projects/${URLEncoder.encode(orgSlug, "UTF-8")}/${URLEncoder.encode(projectSlug, "UTF-8")}/preprodartifacts/check-for-updates/"
)
append("?main_binary_identifier=${URLEncoder.encode(params.mainBinaryIdentifier, "UTF-8")}")
append("&app_id=${URLEncoder.encode(params.appId, "UTF-8")}")
append("?app_id=${URLEncoder.encode(params.appId, "UTF-8")}")
append("&platform=${URLEncoder.encode(params.platform, "UTF-8")}")
append("&build_number=${URLEncoder.encode(params.versionCode.toString(), "UTF-8")}")
append("&build_version=${URLEncoder.encode(params.versionName, "UTF-8")}")
Expand Down
1 change: 0 additions & 1 deletion ...roid-distribution/src/main/java/io/sentry/android/distribution/DistributionIntegration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ public class DistributionIntegration(context: Context) : Integration, IDistribut
val appId = context.applicationInfo.packageName

DistributionHttpClient.UpdateCheckParams(
mainBinaryIdentifier = appId,
appId = appId,
platform = "android",
versionCode = versionCode,
Expand Down
1 change: 0 additions & 1 deletion ...d-distribution/src/test/java/io/sentry/android/distribution/DistributionHttpClientTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class DistributionHttpClientTest {
fun `test checkForUpdates with real API`() {
val params =
DistributionHttpClient.UpdateCheckParams(
mainBinaryIdentifier = "com.emergetools.hackernews",
appId = "com.emergetools.hackernews",
versionName = "1.0.0",
versionCode = 5L,
Expand Down
Loading