feat: Add Supabase Integration #15719
Conversation
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/supabase-integration
branch
2 times, most recently
from
dae5b0f to
80d38ce
Compare
onurtemizkan
force-pushed
the
onur/supabase-integration
branch
5 times, most recently
from
7d5968b to
73d5f23
Compare
onurtemizkan
force-pushed
the
onur/supabase-integration
branch
5 times, most recently
from
927f5ab to
aaec090
Compare
onurtemizkan
force-pushed
the
onur/supabase-integration
branch
from
dabdf90 to
d3a55a1
Compare
onurtemizkan
force-pushed
the
onur/supabase-integration
branch
from
5dd6723 to
33c2a66
Compare
|
lookin good @onurtemizkan! part of getting this in will be updating the docs, and we can do some changelog post and updates to landing page, but i can help with all that it's simple |
|
@smeubank thanks, it would be great! We can then merge in queues support separately. |
onurtemizkan
force-pushed
the
onur/supabase-integration
branch
from
1bc2897 to
d387514
Compare
| AUTH_ADMIN_OPERATIONS_TO_INSTRUMENT.forEach((operation: AuthAdminOperationName) => { | ||
| const authAdminOperation = auth.admin[operation]; | ||
| if (typeof authAdminOperation === 'function') { | ||
| auth.admin[operation] = instrumentAuthOperation(authAdminOperation); |
There was a problem hiding this comment.
Doesn't this need the isAdmin as a second parameter if it is an admin operation? 🤔
Maybe also add a test for the admin behavior.
|
|
||
| function instrumentSupabaseAuthClient(supabaseClientInstance: SupabaseClientInstance): void { | ||
| const auth = supabaseClientInstance.auth; | ||
|
|
There was a problem hiding this comment.
Do we need to check for instrumented.has() here as well?
| type AuthOperationFn = (...args: unknown[]) => Promise<unknown>; | ||
| type AuthOperationName = (typeof AUTH_OPERATIONS_TO_INSTRUMENT)[number]; | ||
| type AuthAdminOperationName = (typeof AUTH_ADMIN_OPERATIONS_TO_INSTRUMENT)[number]; | ||
| type PostgrestQueryOperationName = (typeof AVAILABLE_OPERATIONS)[number]; |
There was a problem hiding this comment.
Just to be sure: This is PostgREST and not PostgreSQL?
Super Nit: Call the variable PostgREST.... so it's easier to read and understand. As it was lower-case, I read PostgreSQL at first sight.
Also valid for all other variable names in the file. But ignore this comment if you think this is not necessary.
There was a problem hiding this comment.
I believe yes @s1gr1d. Some more context here
supabase-community/sentry-integration-js#5 (comment)
and
| const table = pathParts.length > 0 ? pathParts[pathParts.length - 1] : ''; | ||
| const description = `from(${table})`; | ||
|
|
||
| const query: string[] = []; |
There was a problem hiding this comment.
As it's an array, I would suggest adding items to the name. "Query" kinda suggests it's a string.
| const query: string[] = []; | |
| const queryItems: string[] = []; |
| }; | ||
| }) satisfies IntegrationFn; | ||
|
|
||
| export const supabaseIntegration = defineIntegration((supabaseClient: unknown) => { |
There was a problem hiding this comment.
Should the supabaseIntegration be added by default? If yes, then you should add it to getDefaultIntegrations.
Edit: Ah, as the supabase client needs to be passed, it actually cannot be default 🤔
There was a problem hiding this comment.
It's fine to delete this file if it's empty
| // These are the default development keys for a local Supabase instance | ||
| const NEXT_PUBLIC_SUPABASE_URL = 'http://localhost:54321'; | ||
| const SUPABASE_SERVICE_ROLE_KEY = | ||
| 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJzdXBhYmFzZS1kZW1vIiwicm9sZSI6InNlcnZpY2Vfcm9sZSIsImV4cCI6MTk4MzgxMjk5Nn0.EGIM96RAZx35lJzdJsyH-qQwv8Hdp7fsn3W0YpN81IU'; |
There was a problem hiding this comment.
Is it okay to leave this here? Or should we rather add this to the environment?
Same for NEXT_PUBLIC_SUPABASE_ANON_KEY
There was a problem hiding this comment.
These are default local supabase server keys. I think it's ok to leave them here.
Ref: #15436
Summary:
@sentry/coreauthandauth.adminoperations