feat(nextjs): Inject manifest into client for webpack builds #16857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
reviewed
Jul 9, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
chargome
requested review from
a team,
Lms24 and
s1gr1d
and removed request for
a team and
s1gr1d
AbhiPrasad
approved these changes
Jul 14, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Lms24
approved these changes
Jul 15, 2025
| * | ||
| * @default false | ||
| */ | ||
| disableManifestInjection?: boolean; |
There was a problem hiding this comment.
l/feel free to ignore: I generally prefer enableX with default true over disableX with default false flag patterns but not sure if there's already precedence in other options here. To me the enableX pattern is a bit more intuitive from
- a user perspective because they can switch on/off a feature without having to invert it in their mind
- a dev perspective because I don't have to invert the ifs (i.e.
if enableX doX()).
But again, this might be just me, so happy to leave this up to you and no objections to going withdisable here.
msonnb
pushed a commit
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #16683
This PR injects the manifest into client bundles for webpack.