-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Inject manifest into client for webpack builds #16857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
73e0637
build manifest function
chargome 9b28d79
tests
chargome 657dd55
rename file
chargome a82b977
simplify page check
chargome 7d6e198
que
chargome 71b1121
fix handling optional catchall routes
chargome 3114f5c
update if else block
chargome 75305f5
..
chargome 4ad310f
inject manifest
chargome e105620
update interface + rename func
chargome 685bf04
Merge branch 'cg-next-client-manifest' into cg-next-manifest-webpack
chargome f593c49
Merge branch 'develop' into cg-next-client-manifest
chargome 2a4a35c
Merge branch 'cg-next-client-manifest' into cg-next-manifest-webpack
chargome f9430fe
rename option
chargome 6071f76
split routes again
chargome e416a2c
add option for route-groups
chargome 78ff933
Merge branch 'cg-next-client-manifest' into cg-next-manifest-webpack
chargome aeb2e6d
Merge branch 'develop' into cg-next-manifest-webpack
chargome 681cb29
más jsdocs
chargome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l/feel free to ignore: I generally prefer
enableX
with defaulttrue
overdisableX
with defaultfalse
flag patterns but not sure if there's already precedence in other options here. To me the enableX pattern is a bit more intuitive fromif enableX doX()
).But again, this might be just me, so happy to leave this up to you and no objections to going with
disable
here.