ref: Move otel scope out of integrations/opentelemetry/
#4276
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ivana/potel/move-propagator
8 tasks
…o ivana/potel/move-propagator
…-scope-out-of-integrations
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4276 +/- ##
==============================================
+ Coverage 83.55% 83.59% +0.04%
==============================================
Files 144 144
Lines 14631 14631
Branches 2325 2325
==============================================
+ Hits 12225 12231 +6
+ Misses 1690 1683 -7
- Partials 716 717 +1
|
szokeasaurusrex
approved these changes
Apr 10, 2025
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| # TODO-neel-potel make 2 scope strategies/impls and switch | |||
| from sentry_sdk.scope import Scope as BaseScope | |||
| from sentry_sdk.integrations.opentelemetry.scope import ( | |||
| from sentry_sdk.opentelemetry.scope import ( | |||
| PotelScope as Scope, | |||
There was a problem hiding this comment.
[question] are we considering renaming PotelScope to Scope?
There was a problem hiding this comment.
We could, but I'd leave it like this for now so that there's a distinction between the non-otel Scope and PotelScope.
There was a problem hiding this comment.
Eventually we'll merge both -- unless we need to keep both around for errors-only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving stuff out of
integrations/opentelemetry/step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK.This moves
sentry_sdk/integrations/opentelemetry/scope.py->sentry_sdk/opentelemetry/scope.pyRef #3853