test(e2e): De-flake TurboModule span-attribute count assertion - #6596
Merged
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
antonis
force-pushed
the
test/turbomodule-e2e-count-race
branch
from
August 19, 2026 11:12
f3e5888 to
47d94f3
Compare
📲 Install BuildsAndroid
|
antonis
force-pushed
the
test/turbomodule-e2e-count-race
branch
from
August 19, 2026 12:12
47d94f3 to
f42d2f3
Compare
The `turbo_module.*` attribute block is the last content in a long ScrollView, so on the shorter Android emulator screen it renders below the fold. `assertVisible` only inspects the current viewport, so the `turbo_module.total_call_count: 6` assertion has failed on every Android REV2 run since #6549 introduced the test, while iOS (taller screen, block in view) has been green — proving the SDK and on-device render are correct. - Scroll the attribute block into view before asserting, and match the full line with a regex (Maestro anchors `assertVisible` text to the whole node, so a bare `total_call_count:` prefix would not match `... : 6`). - Run the native-throw interaction before that scroll: the throw button is at the top of the screen and must be tapped while the viewport is still there, otherwise scrolling to the attributes pushes it off-screen on Android. The exact on-screen count is intentionally not pinned — it can race the async `getPlatform` record settling against the synchronous post-`end()` read; the authoritative counts are asserted against the transaction envelope in turboModuleSpanAttributes.test.ts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
antonis
force-pushed
the
test/turbomodule-e2e-count-race
branch
from
August 19, 2026 12:40
f42d2f3 to
619f74d
Compare
antonis
commented
Aug 19, 2026
antonis
marked this pull request as ready for review
August 19, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The
Test android production REV2job (Sample Application workflow) has been failing on everymainrun since the TurboModule e2e was introduced in #6549 (Aug 5). It fails on this Maestro assertion:💡 Motivation and Context
Failed checks
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps