Skip to content

test(e2e): De-flake TurboModule span-attribute count assertion #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 3 commits into from
Aug 20, 2026
+15 −6
Merged

test(e2e): De-flake TurboModule span-attribute count assertion #6596

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
619f74d
test(e2e): Fix TurboModule flow viewport on Android emulator
antonis Aug 19, 2026
dbcc73a
Remove uneeded comment
antonis Aug 19, 2026
94153d4
Simplify test comment
antonis Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions samples/react-native/e2e/tests/turboModuleSpanAttributes/turboModuleSpanAttributes.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,22 @@ appId: io.sentry.reactnative.sample
- assertVisible: 'Sync: add x5 = 15'
- assertVisible: 'Async: getPlatform = .*'

# The `turbo_module.*` attributes the TurboModuleContext integration attached
# to the root span are rendered on screen so QA can eyeball them on device.
- assertVisible: 'turbo_module.total_call_count: 6'
- assertVisible: 'turbo_module.total_error_count: 0'

# A native throw surfaced to JS must still be capturable (crash-context path)
- tapOn: 'Throw from native platform'
- extendedWaitUntil:
visible: 'Throw: captured platform throw as .*'
timeout: 30000

# The `turbo_module.*` attributes the TurboModuleContext integration attached
# to the root span are rendered on screen. Scroll it into view before asserting.
# The exact aggregate counts are asserted against the transaction envelope
# in turboModuleSpanAttributes.test.ts, which is the authoritative source.
- scrollUntilVisible:
element:
text: 'turbo_module.total_call_count: .*'
direction: DOWN
timeout: 10000
- scrollUntilVisible:
element:
text: 'turbo_module.total_error_count: 0'
direction: DOWN
timeout: 10000
Comment thread
antonis marked this conversation as resolved.
Loading