-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
ref: remove old devservices #100552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: remove old devservices #100552
Conversation
| return root | ||
|
|
||
|
|
||
| # NOTE: we can delete the docker python client dependency if we port all usage of this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to do this for a bit, but it turned out to be more work than I expected.This seems like a good intermediate step for now to make sure there's no breakage while removing the meat of the old sentry devservices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
https://linear.app/getsentry/issue/DI-560/completely-remove-code-related-to-sentry-devservices this removes old `sentry devservices` and related `SENTRY_DEVSERVICES` (+ all the old configuration files it was referring to) while maintaining compatibility for `get_docker_client` (other than that I've removed support for all other docker runtimes except colima under macos) which is necessary for some scripts and the relay test container getsentry: https://github.com/getsentry/getsentry/pull/18518
since i removed old `sentry devservices` in #100552 we need new devservices to autostart colima which was released as part of 1.2.2 otherwise `devenv sync` will fail if a docker server's not running
https://linear.app/getsentry/issue/DI-560/completely-remove-code-related-to-sentry-devservices
this removes old
sentry devservicesand relatedSENTRY_DEVSERVICES(+ all the old configuration files it was referring to) while maintaining compatibility forget_docker_client(other than that I've removed support for all other docker runtimes except colima under macos) which is necessary for some scripts and the relay test containergetsentry: https://github.com/getsentry/getsentry/pull/18518
supersedes #92512
Note
Removes legacy
sentry devservicesand related configs, standardizes on newdevservices(fixed container names/ports), simplifies Docker runtime handling, and updates scripts/tests accordingly.sentry devservicescodepaths, env flags (e.g.,USE_OLD_DEVSERVICES), and largeSENTRY_DEVSERVICESconfig fromserver.py.sentry devserviceswith newdevservicesusage; add a no-op compatibility stub forsentry.runner.commands.devservices.sentry-postgres-1,kafka-kafka-1) and fixed ports; drop dynamic old/new selection.config/(relay, symbolicator, clickhouse).get_docker_clienton macOS to expect colima socket; remove Docker Desktop/OrbStack handling and auto-start logic.devenv/sync.py,scripts/lib.sh,scripts/upgrade-postgres.sh, andbin/split-silo-databaseto use new devservices and fixed container names.devservices up.devservicesnetwork, fixed hosts/ports, and remove reliance onSENTRY_DEVSERVICESsettings.Written by Cursor Bugbot for commit ffb134d. This will update automatically on new commits. Configure here.