Skip to content

Conversation

@joshuarli
Copy link
Member

@joshuarli joshuarli commented Sep 29, 2025

https://linear.app/getsentry/issue/DI-560/completely-remove-code-related-to-sentry-devservices

this removes old sentry devservices and related SENTRY_DEVSERVICES (+ all the old configuration files it was referring to) while maintaining compatibility for get_docker_client (other than that I've removed support for all other docker runtimes except colima under macos) which is necessary for some scripts and the relay test container

getsentry: https://github.com/getsentry/getsentry/pull/18518

supersedes #92512


Note

Removes legacy sentry devservices and related configs, standardizes on new devservices (fixed container names/ports), simplifies Docker runtime handling, and updates scripts/tests accordingly.

  • Devservices migration:
    • Remove legacy sentry devservices codepaths, env flags (e.g., USE_OLD_DEVSERVICES), and large SENTRY_DEVSERVICES config from server.py.
    • Replace sentry devservices with new devservices usage; add a no-op compatibility stub for sentry.runner.commands.devservices.
    • Standardize container names (e.g., sentry-postgres-1, kafka-kafka-1) and fixed ports; drop dynamic old/new selection.
    • Delete old service configs under config/ (relay, symbolicator, clickhouse).
  • Docker/runtime:
    • Simplify get_docker_client on macOS to expect colima socket; remove Docker Desktop/OrbStack handling and auto-start logic.
  • Tooling/scripts:
    • Update devenv/sync.py, scripts/lib.sh, scripts/upgrade-postgres.sh, and bin/split-silo-database to use new devservices and fixed container names.
    • Adjust Makefile/docs messaging to devservices up.
  • Tests:
    • Update relay/test fixtures and skips to use devservices network, fixed hosts/ports, and remove reliance on SENTRY_DEVSERVICES settings.

Written by Cursor Bugbot for commit ffb134d. This will update automatically on new commits. Configure here.

@joshuarli joshuarli requested review from a team as code owners September 29, 2025 21:03
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 29, 2025
cursor[bot]

This comment was marked as outdated.

return root


# NOTE: we can delete the docker python client dependency if we port all usage of this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do this for a bit, but it turned out to be more work than I expected.This seems like a good intermediate step for now to make sure there's no breakage while removing the meat of the old sentry devservices

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@joshuarli joshuarli merged commit 6d21808 into master Sep 29, 2025
68 checks passed
@joshuarli joshuarli deleted the remove-old-devservices branch September 29, 2025 22:22
jerryzhou196 pushed a commit that referenced this pull request Oct 1, 2025
https://linear.app/getsentry/issue/DI-560/completely-remove-code-related-to-sentry-devservices

this removes old `sentry devservices` and related `SENTRY_DEVSERVICES`
(+ all the old configuration files it was referring to) while
maintaining compatibility for `get_docker_client` (other than that I've
removed support for all other docker runtimes except colima under macos)
which is necessary for some scripts and the relay test container

getsentry: https://github.com/getsentry/getsentry/pull/18518
hubertdeng123 pushed a commit that referenced this pull request Oct 2, 2025
since i removed old `sentry devservices` in #100552 we need new
devservices to autostart colima which was released as part of 1.2.2

otherwise `devenv sync` will fail if a docker server's not running
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants