chore(devservices): Remove all old sentry devservices code #92512
Conversation
github-actions
bot
added
the
Scope: Backend
|
|
||
|
|
||
| @contextlib.contextmanager | ||
| def get_docker_client() -> Generator[docker.DockerClient]: |
There was a problem hiding this comment.
there's a few imports you'll have to address too
[email protected] ~/d/sentry master $ rg -S 'devservices import' 0
bin/split-silo-database
8:from sentry.runner.commands.devservices import get_docker_client
src/sentry/testutils/pytest/relay.py
14:from sentry.runner.commands.devservices import get_docker_client
src/sentry/runner/commands/devserver.py
12:from sentry.runner.commands.devservices import get_docker_client
There was a problem hiding this comment.
yeah, I noticed thought this might be a bit easier to do
There was a problem hiding this comment.
going to punt this until next week or so for now
| except docker.errors.DockerException: | ||
| if DARWIN: | ||
| if USE_COLIMA: | ||
| click.echo("Attempting to start colima...") |
There was a problem hiding this comment.
the expectation before was that devservices would automatically try and start colima if it couldn't connect to a docker daemon
now it's this (and you can't even use --help):
[email protected] ~/d/sentry master $ .venv/bin/devservices up 127
Unable to connect to the docker daemon. Is the docker daemon running?
[email protected] ~/d/sentry master $ .venv/bin/devservices --help 1
Unable to connect to the docker daemon. Is the docker daemon running?
before we remove all this (long awaited!) can we at least get devservices to do this on macos?
There was a problem hiding this comment.
This is now done: getsentry/devservices#293
Gotta run the release tho
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
superseded #100552 |
todo:
Now that
devservices toggleis in, we should be safe to remove this codehttps://linear.app/getsentry/issue/DI-560/completely-remove-code-related-to-sentry-devservices