Skip to content

Allow navigating between book sections' translations #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dscho
Copy link
Member

@dscho dscho commented Sep 26, 2024

Changes

With this PR, the sidebar of the book sections no longer links to the front pages of the translations of the ProGit book. It links to the corresponding translated section (if available).

Context

This addresses #747

@dscho dscho self-assigned this Sep 26, 2024
@dscho dscho force-pushed the allow-navigating-between-book-sections-translations branch from a15f60f to 40d33fd Compare September 26, 2024 12:36
@dscho dscho force-pushed the allow-navigating-between-book-sections-translations branch from 40d33fd to 0428ef0 Compare September 26, 2024 15:49
@dscho dscho marked this pull request as ready for review September 26, 2024 16:03
@dscho dscho changed the title Allow navigating between book sections translations Allow navigating between book sections' translations Sep 26, 2024
@dscho
Copy link
Member Author

dscho commented Oct 13, 2024

I'll just go ahead and merge this PR; In the unlikely case that there should be problems caused by this, I can always fix them swiftly later.

@dscho dscho merged commit b99d8f9 into git:gh-pages Oct 13, 2024
1 check passed
@dscho dscho deleted the allow-navigating-between-book-sections-translations branch October 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant