matching estimates

[vacekj]

frontend pr: gitcoinco/grants-stack#2022
ticket: #307

[vacekj]

@boudra @bard there are two test failures that I'm not immediately sure how to resolve, I'll investigate tomorrow but it might be a quick fix for you.

[bard]

@vacekj I've narrowed it down to tmpNameSync returning the same "temporary" (not so temporary) name twice in a row. Can be seen by console.logging inside PassportProvider.start. Switching to tmpName (async version) didn't help.

Cannot look into it further right now but to debug, you can console.log the dbPath inside PassportProvider.start — as long as it prints the same name more than once, the problem is there. To fix, tmpNameSync in src/passport/index.test.fixtures.ts needs to be replaced with something that actually generates different names.

[boudra]

I can look into it in half an hour, but if it helps i had this exact same problem in my branch when i updated Vitest, downgrading it fixed the problem, very strange.

[boudra]

I pushed a commit to rollback Vitest to 0.34.5 so that we can leave things as they were and we can make fix the passport issue separately since it might not be an obvious fix.

tmpNameSync seems to definitely be generating random paths, the issue I think is with test.extend which seems to be giving each test the same context instead of generating one every time, which maybe is a behaviour change or bug that was introduced in Vitest 0.34.6.