-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[usage] Make billing optional in the usage component #10754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b2ac268
to
cb888d5
Compare
db23cb9
to
3d0814b
Compare
/hold |
ec2065e
to
91b244b
Compare
/werft run 👍 started the job as gitpod-build-af-usage-make-payment-integration-optional.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comments (up to you to address, if you think they are valid)
/hold
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-af-usage-make-payment-integration-optional.27 |
I'm not sure why Werft is failing here 😕 . There are no obvious error message in the logs. The last line of the output is:
|
That test may output a rather long log line. It's possible it doesn't sit well with werft. Main (which contains the same test) is happy however. |
We should probably not run the tests for the usage component in verbose mode as they are very noisy. |
This looks to be more widespread than just this branch. https://werft.gitpod-dev.com/job/gitpod-build-af-add-timeout-show-command.8/raw now also failing at the same point. |
Fix for the debug logging in #10815 |
4c0bcf1
to
9441c48
Compare
548c7d7
to
acd9a2f
Compare
Enable stripe integration iff a Stripe secret is configured.
acd9a2f
to
54c1691
Compare
@gitpod-io/engineering-self-hosted Would you be able to please help review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over the code and it looks good so far. Since we do not own code that is touched in this PR, let me know if you need me to review something in particular.
/unhold |
Description
Make the payment processing part of the usage controller optional. If the secret containing Stripe API keys is configured then enable payments, otherwise disable it.
Usage metering and usage based billing are separate concepts that we will need to enable and disable independently of one another. In Gitpod SaaS we will want both, but for self-hosted installations, users will only care about usage metering.
At some point we will want to have the usage collection and billing integration in separate services but for now, while they both live in the usage component, let's at least be able to toggle billing integration on and off.
Related Issue(s)
Part of #9036
How to test
with-payment=true
and the other without.Release Notes
Documentation
None