Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show User ID on Account page #17956

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Show User ID on Account page #17956

merged 2 commits into from
Jun 19, 2023

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Jun 15, 2023

Description

Surfaces the user's ID through the Account settings in the Dashboard.

image

Related Issue(s)

Falls under #15654

How to test

Open the Dashboard in the preview environment :)

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@filiptronicek
Copy link
Member Author

filiptronicek commented Jun 15, 2023

/gh run recreate-vm=true

Comment triggered a workflow run

Started workflow run: 5281429602

  • recreate_vm: true

@loujaybee
Copy link
Member

We have a community session scheduled next week on the 21st [1]. I'd love if this were able to get merged by then, as I can ask users to share their ID's with us for inclusion in the private beta. Right now it's a painful process of having to ask someone with admin access to map a user name or email to get the ID for inclusion in private betas or feature flags. Having this in would be a big help 🙏

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks shippable, @filiptronicek. :shipit:

We could later on think how we can improve the user profile layout so that resource IDs show up consistently, but this already looks like an improvement.

Approving to unblock merging. 🏁

Looping in @gitpod-io/engineering-webapp in case code changes need a closer look although seem trivial. 🏓

@filiptronicek filiptronicek marked this pull request as ready for review June 17, 2023 09:14
@filiptronicek filiptronicek requested a review from a team June 17, 2023 09:14
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 17, 2023
@filiptronicek
Copy link
Member Author

Let's :shipit: and iterate later

/unhold your horses folks

@roboquat roboquat merged commit 283aa6c into main Jun 19, 2023
@roboquat roboquat deleted the ft/user-ids-in-dashboard branch June 19, 2023 07:06
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 19, 2023
@gtsiolis
Copy link
Contributor

Thanks for taking a bias for action, @filiptronicek. ✨

@gtsiolis gtsiolis mentioned this pull request Jun 21, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard deployed: webapp Meta team change is running in production deployed Change is completely running in production size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants