Rename copy user ID tooltip #18005
Rename copy user ID tooltip #18005
Conversation
| @@ -162,7 +162,7 @@ function ProfileInformation(props: { | |||
| <div className="flex flex-col space-y-2 mt-4"> | |||
| <label className={"text-md font-semibold dark:text-gray-400 text-gray-600"}>User ID</label> | |||
| <p className={"text-sm text-gray-500 dark:text-gray-500"}> | |||
| <InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy Token" /> | |||
| <InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy User ID" /> | |||
There was a problem hiding this comment.
What if we left it at just Copy?
There was a problem hiding this comment.
I'm with Milan on this one, keepin' it simple.
There was a problem hiding this comment.
Thanks @easyCZ & @filiptronicek!
Using concise language that conveys what happens when the button is activated is recommended. I understand the intent behind simplifying this but using just Copy as the tooltip label can easily cause some confusion as it's not clear what are you copying, is this a string, a JSON object, something else?
Still, no right or wrong approach but I'm inclined to merge this as is to follow the pattern we've been using across the product for all the copy-to-clipboard buttons using the InputWithCopy component.
Let's open an issue to discuss further if needed. 🏓
gtsiolis
force-pushed
the
gt/rename-copy-user-id-tooltip
branch
from
fa4dcca to
cf0a4b7
Compare
| @@ -162,7 +162,7 @@ function ProfileInformation(props: { | |||
| <div className="flex flex-col space-y-2 mt-4"> | |||
| <label className={"text-md font-semibold dark:text-gray-400 text-gray-600"}>User ID</label> | |||
| <p className={"text-sm text-gray-500 dark:text-gray-500"}> | |||
| <InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy Token" /> | |||
| <InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy User ID" /> | |||
There was a problem hiding this comment.
| <InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy User ID" /> | |
| <InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy" /> |
|
Thanks for taking a look, @easyCZ & @filiptronicek. 🌮 /unhold |
roboquat
added
deployed: webapp
Description
Minor tooltip change for copying the user ID.
Follow-up from #17956. Cc @filiptronicek @loujaybee
How to test
Go to
/user/accountand try to copy the new user ID field. The tooltip should use a new label.Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold