Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename copy user ID tooltip #18005

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Rename copy user ID tooltip #18005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/dashboard/src/user-settings/Account.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ function ProfileInformation(props: {
<div className="flex flex-col space-y-2 mt-4">
<label className={"text-md font-semibold dark:text-gray-400 text-gray-600"}>User ID</label>
<p className={"text-sm text-gray-500 dark:text-gray-500"}>
<InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy Token" />
<InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy User ID" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we left it at just Copy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm with Milan on this one, keepin' it simple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @easyCZ & @filiptronicek!

Using concise language that conveys what happens when the button is activated is recommended. I understand the intent behind simplifying this but using just Copy as the tooltip label can easily cause some confusion as it's not clear what are you copying, is this a string, a JSON object, something else?

Still, no right or wrong approach but I'm inclined to merge this as is to follow the pattern we've been using across the product for all the copy-to-clipboard buttons using the InputWithCopy component.

Let's open an issue to discuss further if needed. 🏓

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy User ID" />
<InputWithCopy className="max-w-md w-32" value={props.user.id} tip="Copy" />

</p>
</div>
)}
Expand Down