refactor(gnovm): not recursive save when object is dirty

gnovm/pkg/gnolang/realm.go

@@ -750,7 +750,9 @@ func (rlm *Realm) saveUnsavedObjects(store Store) {
 			continue
 		} else {
 			if !uo.GetIsDeleted() {
-				rlm.saveUnsavedObjectRecursively(store, uo, tids)
+				rlm.assertObjectIsPublic(uo, store, tids)
+				rlm.saveObject(store, uo)
+				uo.SetIsDirty(false, 0)
 			}
 		}
 	}

gnovm/tests/files/append8.gno

@@ -0,0 +1,29 @@
+// PKGPATH: gno.land/r/main
+package main
+
+var bs []byte = make([]byte, 0, 10)
+
+func init() {
+	_ = append(bs, byte('a'), byte('b'), byte('c'))
+}
+
+func main() {
+	println(string(bs[0:3]))
+	_ = append(bs, byte('a'), byte('b'), byte('c'), byte('d'))
+	println(string(bs[0:4]))
+}
+
+// Output:
+// abc
+// abcd
+
+// Realm:
+// finalizerealm["gno.land/r/main"]
+// u[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4](0)=
+//     @@ -1,5 +1,5 @@
+//      {
+//     -    "Data": "YWJjAAAAAAAAAA==",
+//     +    "Data": "YWJjZAAAAAAAAA==",
+//          "List": null,
+//          "ObjectInfo": {
+//              "ID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4",

gnovm/tests/files/append8b.gno

@@ -0,0 +1,32 @@
+// PKGPATH: gno.land/r/main
+package main
+
+import "fmt"
+
+var bs []int = make([]int, 0, 10)
+
+func init() {
+	_ = append(bs, 1, 2, 3)
+}
+
+func main() {
+	fmt.Println(bs[0:3])
+	_ = append(bs, 1, 2, 3, 4)
+	fmt.Println(bs[0:4])
+}
+
+// Output:
+// [1 2 3]
+// [1 2 3 4]
+
+// Realm:
+// finalizerealm["gno.land/r/main"]
+// u[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4](0)=
+//     @@ -23,6 +23,7 @@
+//                  }
+//              },
+//              {
+//     +            "N": "BAAAAAAAAAA=",
+//                  "T": {
+//                      "@type": "/gno.PrimitiveType",
+//                      "value": "32"

gnovm/tests/files/append8c.gno

@@ -0,0 +1,157 @@
+// PKGPATH: gno.land/r/main
+package main
+
+import "fmt"
+
+type S struct {
+	A int
+}
+
+var bs []S = make([]S, 0, 10)
+
+func init() {
+	_ = append(bs, S{1}, S{2}, S{3})
+}
+
+func main() {
+	fmt.Println(bs[0:3])
+	_ = append(bs, S{1}, S{2}, S{3}, S{4})
+	fmt.Println(bs[0:4])
+}
+
+// Output:
+// [{1} {2} {3}]
+// [{1} {2} {3} {4}]
+
+// Realm:
+// finalizerealm["gno.land/r/main"]
+// c[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:21](215)={
+//     "Fields": [
+//         {
+//             "N": "AQAAAAAAAAA=",
+//             "T": {
+//                 "@type": "/gno.PrimitiveType",
+//                 "value": "32"
+//             }
+//         }
+//     ],
+//     "ObjectInfo": {
+//         "ID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:21",
+//         "LastObjectSize": "215",
+//         "ModTime": "0",
+//         "OwnerID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4",
+//         "RefCount": "1"
+//     }
+// }
+// c[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:22](215)={
+//     "Fields": [
+//         {
+//             "N": "AgAAAAAAAAA=",
+//             "T": {
+//                 "@type": "/gno.PrimitiveType",
+//                 "value": "32"
+//             }
+//         }
+//     ],
+//     "ObjectInfo": {
+//         "ID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:22",
+//         "LastObjectSize": "215",
+//         "ModTime": "0",
+//         "OwnerID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4",
+//         "RefCount": "1"
+//     }
+// }
+// c[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:23](215)={
+//     "Fields": [
+//         {
+//             "N": "AwAAAAAAAAA=",
+//             "T": {
+//                 "@type": "/gno.PrimitiveType",
+//                 "value": "32"
+//             }
+//         }
+//     ],
+//     "ObjectInfo": {
+//         "ID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:23",
+//         "LastObjectSize": "215",
+//         "ModTime": "0",
+//         "OwnerID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4",
+//         "RefCount": "1"
+//     }
+// }
+// c[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:24](215)={
+//     "Fields": [
+//         {
+//             "N": "BAAAAAAAAAA=",
+//             "T": {
+//                 "@type": "/gno.PrimitiveType",
+//                 "value": "32"
+//             }
+//         }
+//     ],
+//     "ObjectInfo": {
+//         "ID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:24",
+//         "LastObjectSize": "215",
+//         "ModTime": "0",
+//         "OwnerID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4",
+//         "RefCount": "1"
+//     }
+// }
+// u[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4](1)=
+//     @@ -8,8 +8,8 @@
+//                  },
+//                  "V": {
+//                      "@type": "/gno.RefValue",
+//     -                "Hash": "b64e6d66625500a1a73ad3aa83bf64a19e5ef79c",
+//     -                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:18"
+//     +                "Hash": "a50095053b0560d6000a853698d2a70398b43ff0",
+//     +                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:21"
+//                  }
+//              },
+//              {
+//     @@ -19,8 +19,8 @@
+//                  },
+//                  "V": {
+//                      "@type": "/gno.RefValue",
+//     -                "Hash": "044a7cc5cdc8d198ee0de4c97b17542ba2bcc45d",
+//     -                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:19"
+//     +                "Hash": "4bd56d347d1de8616331e0c7e9d24f2e660b7506",
+//     +                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:22"
+//                  }
+//              },
+//              {
+//     @@ -30,8 +30,8 @@
+//                  },
+//                  "V": {
+//                      "@type": "/gno.RefValue",
+//     -                "Hash": "c2c402289358af04b4bcc1263a34b23304591963",
+//     -                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:20"
+//     +                "Hash": "0fd141d953069d60bf97cb84881f33976f022e11",
+//     +                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:23"
+//                  }
+//              },
+//              {
+//     @@ -41,8 +41,8 @@
+//                  },
+//                  "V": {
+//                      "@type": "/gno.RefValue",
+//     -                "Hash": "6f563d96f793175f993169399dc7a9b7ff7f5682",
+//     -                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:8"
+//     +                "Hash": "34ef9d7fdb562e442c9fef95bc3c06f7613b119b",
+//     +                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:24"
+//                  }
+//              },
+//              {
+//     @@ -115,7 +115,7 @@
+//          "ObjectInfo": {
+//              "ID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4",
+//              "LastObjectSize": "1738",
+//     -        "ModTime": "17",
+//     +        "ModTime": "20",
+//              "OwnerID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:3",
+//              "RefCount": "1"
+//          }
+// d[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:18](-215)
+// d[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:19](-215)
+// d[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:20](-215)
+// d[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:8](-214)

gnovm/tests/files/storage/struct4.gno

@@ -70,25 +70,6 @@ func main() {
 //              "OwnerID": "34f997a9ca158338c03cfc00686d77220a6cf62f:11",
 //              "RefCount": "1"
 //          }
-// u[34f997a9ca158338c03cfc00686d77220a6cf62f:11](5)=
-//     @@ -2,7 +2,7 @@
-//          "ObjectInfo": {
-//              "ID": "34f997a9ca158338c03cfc00686d77220a6cf62f:11",
-//              "LastObjectSize": "340",
-//     -        "ModTime": "0",
-//     +        "ModTime": "12",
-//              "OwnerID": "34f997a9ca158338c03cfc00686d77220a6cf62f:5",
-//              "RefCount": "1"
-//          },
-//     @@ -13,7 +13,7 @@
-//              },
-//              "V": {
-//                  "@type": "/gno.RefValue",
-//     -            "Hash": "2b6a1dd38af88a40a05ffd55e77e7ea3b4b3a156",
-//     +            "Hash": "6c3ebd5509617364a76aada1372a2c3f2afa0dc4",
-//                  "ObjectID": "34f997a9ca158338c03cfc00686d77220a6cf62f:12"
-//              }
-//          }
 // u[34f997a9ca158338c03cfc00686d77220a6cf62f:6](135)=
 //     @@ -2,7 +2,7 @@
 //          "ObjectInfo": {
@@ -99,7 +80,7 @@ func main() {
 //              "OwnerID": "34f997a9ca158338c03cfc00686d77220a6cf62f:2",
 //              "RefCount": "1"
 //          },
-//     @@ -13,6 +13,16 @@
+//     @@ -13,6 +13,15 @@
 //                      "@type": "/gno.RefType",
 //                      "ID": "gno.land/r/storage.Foo"
 //                  }
@@ -108,14 +89,32 @@ func main() {
 //     +            "@type": "/gno.PointerValue",
 //     +            "Base": {
 //     +                "@type": "/gno.RefValue",
-//     +                "Hash": "dfbf2681f241a888fa3f782d8a6d8a42607ff63d",
 //     +                "ObjectID": "34f997a9ca158338c03cfc00686d77220a6cf62f:11"
 //     +            },
 //     +            "Index": "0",
 //     +            "TV": null
 //              }
 //          }
 //      }
+// u[34f997a9ca158338c03cfc00686d77220a6cf62f:11](5)=
+//     @@ -2,7 +2,7 @@
+//          "ObjectInfo": {
+//              "ID": "34f997a9ca158338c03cfc00686d77220a6cf62f:11",
+//              "LastObjectSize": "340",
+//     -        "ModTime": "0",
+//     +        "ModTime": "12",
+//              "OwnerID": "34f997a9ca158338c03cfc00686d77220a6cf62f:5",
+//              "RefCount": "1"
+//          },
+//     @@ -13,7 +13,7 @@
+//              },
+//              "V": {
+//                  "@type": "/gno.RefValue",
+//     -            "Hash": "2b6a1dd38af88a40a05ffd55e77e7ea3b4b3a156",
+//     +            "Hash": "6c3ebd5509617364a76aada1372a2c3f2afa0dc4",
+//                  "ObjectID": "34f997a9ca158338c03cfc00686d77220a6cf62f:12"
+//              }
+//          }
 // u[34f997a9ca158338c03cfc00686d77220a6cf62f:3](0)=
 //     @@ -2,7 +2,7 @@
 //          "ObjectInfo": {

gnovm/tests/files/struct63.gno

@@ -0,0 +1,89 @@
+// PKGPATH: gno.land/r/main
+package main
+
+type A struct {
+	b B
+}
+
+type B struct {
+	c C
+}
+
+type C struct {
+	d D
+}
+
+type D struct {
+	e int
+}
+
+var x = A{b: B{c: C{d: D{e: 1}}}}
+
+func main() {
+	x.b.c = C{d: D{e: 2}}
+}
+
+// Realm:
+// finalizerealm["gno.land/r/main"]
+// c[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:11](216)={
+//     "Fields": [
+//         {
+//             "N": "AgAAAAAAAAA=",
+//             "T": {
+//                 "@type": "/gno.PrimitiveType",
+//                 "value": "32"
+//             }
+//         }
+//     ],
+//     "ObjectInfo": {
+//         "ID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:11",
+//         "LastObjectSize": "216",
+//         "ModTime": "0",
+//         "OwnerID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:10",
+//         "RefCount": "1"
+//     }
+// }
+// c[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:10](333)={
+//     "Fields": [
+//         {
+//             "T": {
+//                 "@type": "/gno.RefType",
+//                 "ID": "gno.land/r/main.D"
+//             },
+//             "V": {
+//                 "@type": "/gno.RefValue",
+//                 "Hash": "9ecaaba55c8400d0a9b7f90804afeebeccd80a79",
+//                 "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:11"
+//             }
+//         }
+//     ],
+//     "ObjectInfo": {
+//         "ID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:10",
+//         "LastObjectSize": "333",
+//         "ModTime": "0",
+//         "OwnerID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:5",
+//         "RefCount": "1"
+//     }
+// }
+// u[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:5](6)=
+//     @@ -7,15 +7,15 @@
+//                  },
+//                  "V": {
+//                      "@type": "/gno.RefValue",
+//     -                "Hash": "0838a9b6bc9a600cf3efff9dd11c009eda1a6cc2",
+//     -                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:6"
+//     +                "Hash": "6a3c6de5e326bc3f5905a4223efd057103f1eec0",
+//     +                "ObjectID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:10"
+//                  }
+//              }
+//          ],
+//          "ObjectInfo": {
+//              "ID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:5",
+//              "LastObjectSize": "331",
+//     -        "ModTime": "0",
+//     +        "ModTime": "9",
+//              "OwnerID": "f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:4",
+//              "RefCount": "1"
+//          }
+// d[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:6](-331)
+// d[f9b6b63cc3f789fda754d95769bbf99bf64c5cb4:7](-214)