Skip to content

Conversation

@wass3r
Copy link
Collaborator

@wass3r wass3r commented Nov 8, 2025

fixes go-vela/community#119

for affected containers, sets step state properly on build timeout or other error before it takes a snapshot, on timeout it marks container with exit code 137 and sets error message, on other error it uses generic exit code 1.

before:
step-status-before

after:
step-status-after

was really tempted to also update build error message to be clearer, but saving it for a different PR.

@wass3r wass3r requested a review from a team as a code owner November 8, 2025 03:59
@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.92%. Comparing base (5b043e9) to head (44d11dd).

Files with missing lines Patch % Lines
mock/docker/container.go 0.00% 6 Missing ⚠️
executor/linux/step.go 86.95% 2 Missing and 1 partial ⚠️
executor/local/step.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   52.62%   52.92%   +0.30%     
==========================================
  Files         124      124              
  Lines        5361     5413      +52     
==========================================
+ Hits         2821     2865      +44     
- Misses       2320     2328       +8     
  Partials      220      220              
Files with missing lines Coverage Δ
executor/linux/step.go 76.07% <86.95%> (+2.42%) ⬆️
executor/local/step.go 90.90% <86.95%> (+1.43%) ⬆️
mock/docker/container.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wass3r wass3r changed the title fix: record proper step state on timeout fix: record proper step state on build timeout Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If a build fails at a step due to timeout, step is shown as passed instead of failed

5 participants