Skip to content

[3.x] Physics Interpolation - Add editor warning for non-interpolated PhysicsBody#103355

Merged
lawnjelly merged 1 commit into
godotengine:3.xfrom
lawnjelly:fti_warn_physics_non_interp
May 17, 2025
Merged

[3.x] Physics Interpolation - Add editor warning for non-interpolated PhysicsBody#103355
lawnjelly merged 1 commit into
godotengine:3.xfrom
lawnjelly:fti_warn_physics_non_interp

Conversation

@lawnjelly
Copy link
Copy Markdown
Member

@lawnjelly lawnjelly commented Feb 27, 2025

Helps address #103232 (comment)

non_interp_warning

Notes

  • I had not encountered this before, but it may not be obvious to users that physics bodies won't work correctly on non-interpolated branches of the scene tree.
  • This is simple to add and warns of the problem, and how to fix it.
  • The warning will show even in projects not using physics interpolation, but in most cases users will not have been changing physics_interpolation_mode except by accident. There's not a super easy way to check the global interpolation switch in the editor (except via the project setting) as it is hard coded OFF in the editor.
  • It is also possible to add some warnings at runtime for this (perhaps if the user switches interpolation mode of a branch at runtime) but seems less likely and can be added in a follow up PR.
  • Also relevant to 4.x.

@lawnjelly lawnjelly added enhancement topic:rendering topic:editor cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Feb 27, 2025
@lawnjelly lawnjelly added this to the 3.7 milestone Feb 27, 2025
@lawnjelly lawnjelly requested review from a team as code owners February 27, 2025 10:53
@lawnjelly lawnjelly force-pushed the fti_warn_physics_non_interp branch from 65553c9 to 13412ff Compare March 3, 2025 10:31
@lawnjelly lawnjelly requested a review from a team as a code owner March 3, 2025 10:31
@lawnjelly lawnjelly force-pushed the fti_warn_physics_non_interp branch from 13412ff to 9ad7306 Compare April 20, 2025 08:56
@lawnjelly
Copy link
Copy Markdown
Member Author

Repushed this to remove the warnings on interpolated Spatials that were children of non-interpolated nodes, as this may now be possible with the new SceneTreeFTI, or at least I would like to establish that it can't be done before introducing a warning.

@lawnjelly lawnjelly requested review from Calinou and rburing April 20, 2025 09:09
@lawnjelly lawnjelly requested a review from Ivorforce May 17, 2025 16:01
@lawnjelly
Copy link
Copy Markdown
Member Author

Linked @Ivorforce as reviewed #103504 and this is the same for 3.x.

@Ivorforce
Copy link
Copy Markdown
Member

It's fine to me, but i was hoping to get an editor review on #103504 so we could transitively accept this one too

@lawnjelly
Copy link
Copy Markdown
Member Author

lawnjelly commented May 17, 2025

There's no need imo, changing the configuration warnings is pretty straight forward (it's more the wording etc).

It's also a catch22, you'll likely not get an editor review as editor guys aren't familiar enough to approve physics interpolation. 😁

Also bear in mind the relevant teams will get flagged automatically, if it doesn't get a prompt review things just tend to languish in approval purgatory without pinging a specific member.

@lawnjelly lawnjelly merged commit 958a7c9 into godotengine:3.x May 17, 2025
@lawnjelly
Copy link
Copy Markdown
Member Author

Thanks!

@lawnjelly lawnjelly deleted the fti_warn_physics_non_interp branch May 17, 2025 17:15
@lawnjelly
Copy link
Copy Markdown
Member Author

Cherry-picked for 3.6.1.

@lawnjelly lawnjelly removed the cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release label May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants