Skip to content

[3.x] Physics Interpolation - Add editor warning for non-interpolated PhysicsBody #103355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawnjelly merged 1 commit into from
May 17, 2025
Merged

[3.x] Physics Interpolation - Add editor warning for non-interpolated PhysicsBody #103355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion scene/2d/physics_body_2d.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,19 @@ void PhysicsBody2D::_bind_methods() {
ADD_PROPERTY(PropertyInfo(Variant::INT, "layers", PROPERTY_HINT_LAYERS_2D_PHYSICS, "", 0), "_set_layers", "_get_layers"); //for backwards compat
}

String PhysicsBody2D::get_configuration_warning() const {
String warning = CollisionObject2D::get_configuration_warning();

if (!is_physics_interpolated()) {
if (!warning.empty()) {
warning += "\n\n";
}
warning += TTR("PhysicsBody2D will not work correctly on a non-interpolated branch of the SceneTree.\nCheck the node's inherited physics_interpolation_mode.");
}

return warning;
}

PhysicsBody2D::PhysicsBody2D(Physics2DServer::BodyMode p_mode) :
CollisionObject2D(RID_PRIME(Physics2DServer::get_singleton()->body_create()), false) {
Physics2DServer::get_singleton()->body_set_mode(get_rid(), p_mode);
Expand Down Expand Up @@ -808,7 +821,7 @@ void RigidBody2D::_notification(int p_what) {
String RigidBody2D::get_configuration_warning() const {
Transform2D t = get_transform();

String warning = CollisionObject2D::get_configuration_warning();
String warning = PhysicsBody2D::get_configuration_warning();

if ((get_mode() == MODE_RIGID || get_mode() == MODE_CHARACTER) && (ABS(t.elements[0].length() - 1.0) > 0.05 || ABS(t.elements[1].length() - 1.0) > 0.05)) {
if (warning != String()) {
Expand Down
2 changes: 2 additions & 0 deletions scene/2d/physics_body_2d.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ class PhysicsBody2D : public CollisionObject2D {
static void _bind_methods();

public:
virtual String get_configuration_warning() const;

Array get_collision_exceptions();
void add_collision_exception_with(Node *p_node); //must be physicsbody
void remove_collision_exception_with(Node *p_node);
Expand Down
15 changes: 14 additions & 1 deletion scene/3d/physics_body.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,19 @@ void PhysicsBody::_bind_methods() {
ClassDB::bind_method(D_METHOD("_get_layers"), &PhysicsBody::_get_layers);
}

String PhysicsBody::get_configuration_warning() const {
String warning = CollisionObject::get_configuration_warning();

if (!is_physics_interpolated()) {
if (!warning.empty()) {
warning += "\n\n";
}
warning += TTR("PhysicsBody will not work correctly on a non-interpolated branch of the SceneTree.\nCheck the node's inherited physics_interpolation_mode.");
}

return warning;
}

PhysicsBody::PhysicsBody(PhysicsServer::BodyMode p_mode) :
CollisionObject(RID_PRIME(PhysicsServer::get_singleton()->body_create(p_mode)), false) {
}
Expand Down Expand Up @@ -783,7 +796,7 @@ Array RigidBody::get_colliding_bodies() const {
String RigidBody::get_configuration_warning() const {
Transform t = get_transform();

String warning = CollisionObject::get_configuration_warning();
String warning = PhysicsBody::get_configuration_warning();

if ((get_mode() == MODE_RIGID || get_mode() == MODE_CHARACTER) && (ABS(t.basis.get_axis(0).length() - 1.0) > 0.05 || ABS(t.basis.get_axis(1).length() - 1.0) > 0.05 || ABS(t.basis.get_axis(2).length() - 1.0) > 0.05)) {
if (warning != String()) {
Expand Down
2 changes: 2 additions & 0 deletions scene/3d/physics_body.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ class PhysicsBody : public CollisionObject {
PhysicsBody(PhysicsServer::BodyMode p_mode);

public:
virtual String get_configuration_warning() const;

virtual Vector3 get_linear_velocity() const;
virtual Vector3 get_angular_velocity() const;
virtual float get_inverse_mass() const;
Expand Down
2 changes: 2 additions & 0 deletions scene/main/node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ void Node::_propagate_physics_interpolated(bool p_interpolated) {
// allow a call to the VisualServer etc in derived classes
_physics_interpolated_changed();

update_configuration_warning();

data.blocked++;
for (int i = 0; i < data.children.size(); i++) {
data.children[i]->_propagate_physics_interpolated(p_interpolated);
Expand Down