Skip to content

Add fuzzy filtering to the script filtering#105239

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Arnklit:script-fuzzy-filtering
May 28, 2025
Merged

Add fuzzy filtering to the script filtering#105239
Repiteo merged 1 commit into
godotengine:masterfrom
Arnklit:script-fuzzy-filtering

Conversation

@Arnklit
Copy link
Copy Markdown
Contributor

@Arnklit Arnklit commented Apr 10, 2025

Would close- godotengine/godot-proposals#11089
Incorrect proposal, that one is for method filtering, I will do a separate PR for that, I realise I didn't log a proposal for the script filtering one. I can log one if needed.

Before:

Godot_v4.4.1-stable_win64_Cgilg5Bofq.mp4

After:

godot.windows.editor.dev.x86_64_ichztKCGkk.mp4

Copy link
Copy Markdown
Contributor

@kitbdev kitbdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Comment thread editor/plugins/script_editor_plugin.cpp Outdated
@Arnklit
Copy link
Copy Markdown
Contributor Author

Arnklit commented Apr 29, 2025

Rebased and disabled case sensitivity as suggested by @kitbdev. However there seems to be a bug in the fuzzy search code so it doesn't work to disable case sensitivity. I opened a PR to fix that. #105900

Comment thread editor/plugins/script_editor_plugin.cpp Outdated
@Arnklit Arnklit marked this pull request as draft May 26, 2025 11:48
@Arnklit Arnklit force-pushed the script-fuzzy-filtering branch 2 times, most recently from ca5ea0c to ae4f342 Compare May 26, 2025 12:16
@Arnklit
Copy link
Copy Markdown
Contributor Author

Arnklit commented May 26, 2025

Took advantage of the original index now that #105930 is merged which simplifies it a and I rebased it.

Still waiting for #105996 to be merged before this can be tested with proper case insensitivity.

@Arnklit Arnklit force-pushed the script-fuzzy-filtering branch from ae4f342 to 7dc9a08 Compare May 27, 2025 08:09
@Arnklit Arnklit marked this pull request as ready for review May 27, 2025 08:10
@Arnklit
Copy link
Copy Markdown
Contributor Author

Arnklit commented May 27, 2025

Rebased now that the case sensitivity fix is merged. Ready for review.

@kitbdev kitbdev modified the milestones: 4.x, 4.5 May 27, 2025
Copy link
Copy Markdown
Contributor

@kitbdev kitbdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good.
Adds the same include that #105240 does, but I don't think it will cause a conflict when merging both, since they are the same.

@Repiteo Repiteo merged commit 5c5708e into godotengine:master May 28, 2025
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented May 28, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants