Only update case sensitive fuzzy searching within set_query#105996
Merged
Conversation
a-johnston
changed the title
a-johnston
force-pushed
the
fuzzy_search_case_fix
branch
from
61f4639 to
76a65de
Compare
akien-mga
changed the title
set_query
akien-mga
approved these changes
May 26, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #105900. There is a bit of discussion on that pr about possible approaches and changes to the behavior; I would be open to further changes such as removing case sensitive filtering entirely but this is the smallest change which I thought made sense. Potentially it makes sense to preemptively make the other "config" variables also private but I think
case_sensitiveis unique in that the stored token values change wrt to its value while the other vars only affect the returned values.Unblocks #105239 and #105240