Web: Don't try to send process ID over the debugger#106497
Closed
akien-mga wants to merge 1 commit into
Closed
Conversation
Silences an error about `OS::get_process_id()` not being implemented on Web.
adamscott
requested changes
May 16, 2025
Member
There was a problem hiding this comment.
While I feel this is the quickest way to fix the annoying bug, I think we should maybe add instead bool OS::has_process_id() const that is true for pretty much all the platforms except for the Web.
tl;dr I don't like having platform specific code in core/.
Collaborator
|
I think we could also just have |
Member
Author
|
Superseded by #106504. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silences an error about
OS::get_process_id()not being implemented on Web.I didn't check whether the editor expects to receive this message with a valid process ID, but in a quick test things seem to work, and previously the ID would be invalid anyway. Might still be worth a quick check from someone familiar with the debugger (cc @Faless ).