Skip to content

[Web] Always return 0 for OS::get_process_id()#106504

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
adamscott:return-without-error-os-get-process-id
May 19, 2025
Merged

[Web] Always return 0 for OS::get_process_id()#106504
Repiteo merged 1 commit into
godotengine:masterfrom
adamscott:return-without-error-os-get-process-id

Conversation

@adamscott
Copy link
Copy Markdown
Member

Supersedes #106497.

Removes the obnoxious error complaining that OS::get_process_id() is not implemented on Web.

Changes the documentation to mention that it always return 0 on Web.

@adamscott adamscott added this to the 4.5 milestone May 16, 2025
@adamscott adamscott requested review from a team as code owners May 16, 2025 19:48
@adamscott adamscott requested a review from akien-mga May 16, 2025 19:48
Copy link
Copy Markdown
Member

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well not list the platforms if it's practically all platforms, yes.

@Repiteo Repiteo merged commit 41bc5ea into godotengine:master May 19, 2025
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented May 19, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants