Skip to content

Rendering: Pre-allocate light vectors in scene culling #114329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kellemar wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −8
Open

Rendering: Pre-allocate light vectors in scene culling #114329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d615ae
Rendering: Pre-allocate light vectors in scene culling
kellemar Dec 25, 2025
48d3444
Rendering: move light vectors to class members for reuse
kellemar Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions servers/rendering/renderer_scene_cull.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3156,19 +3156,19 @@ void RendererSceneCull::_render_scene(const RendererSceneRender::CameraData *p_c
Vector<Plane> planes = p_camera_data->main_projection.get_projection_planes(p_camera_data->main_transform);
cull.frustum = Frustum(planes);

Vector<RID> directional_lights;
directional_light_instances.clear();
lights_with_shadow.clear();

// directional lights
{
cull.shadow_count = 0;

Vector<Instance *> lights_with_shadow;

for (Instance *E : scenario->directional_lights) {
if (!E->visible || !(E->layer_mask & p_visible_layers)) {
continue;
}

if (directional_lights.size() >= RendererSceneRender::MAX_DIRECTIONAL_LIGHTS) {
if (directional_light_instances.size() >= RendererSceneRender::MAX_DIRECTIONAL_LIGHTS) {
break;
}

Expand All @@ -3181,7 +3181,7 @@ void RendererSceneCull::_render_scene(const RendererSceneRender::CameraData *p_c
lights_with_shadow.push_back(E);
}
//add to list
directional_lights.push_back(light->instance);
directional_light_instances.push_back(light->instance);
}
}

Expand Down Expand Up @@ -3456,15 +3456,15 @@ void RendererSceneCull::_render_scene(const RendererSceneRender::CameraData *p_c
}

if (p_reflection_probe.is_null()) {
sdfgi_update_data.directional_lights = &directional_lights;
sdfgi_update_data.directional_lights = &directional_light_instances;
sdfgi_update_data.positional_light_instances = scenario->dynamic_lights.ptr();
sdfgi_update_data.positional_light_count = scenario->dynamic_lights.size();
}
}

//append the directional lights to the lights culled
for (int i = 0; i < directional_lights.size(); i++) {
scene_cull_result.light_instances.push_back(directional_lights[i]);
for (int i = 0; i < directional_light_instances.size(); i++) {
scene_cull_result.light_instances.push_back(directional_light_instances[i]);
}

RID camera_attributes;
Expand Down
3 changes: 3 additions & 0 deletions servers/rendering/renderer_scene_cull.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,6 +1002,9 @@ class RendererSceneCull : public RenderingMethod {
InstanceCullResult scene_cull_result;
LocalVector<InstanceCullResult> scene_cull_result_threads;

Vector<RID> directional_light_instances;
Vector<Instance *> lights_with_shadow;

RendererSceneRender::RenderShadowData render_shadow_data[MAX_UPDATE_SHADOWS];
uint32_t max_shadows_used = 0;

Expand Down