Fix "Open Documentation" ignoring non-top-level nodes#119908
Merged
Conversation
EdwardChanCH
changed the title
Open Documentation ignoring non-top-level nodes
EdwardChanCH
force-pushed
the
fix_open_doc_selection
branch
from
f23d114 to
81765fd
Compare
KoBeWi
reviewed
Jun 2, 2026
Comment on lines
1314
to
1316
| // TODO: Rename selection to full_selection? | ||
| const List<Node *> selection = editor_selection->get_full_selected_node_list(); | ||
| for (const Node *node : selection) { |
Member
There was a problem hiding this comment.
Suggested change
| // TODO: Rename selection to full_selection? | |
| const List<Node *> selection = editor_selection->get_full_selected_node_list(); | |
| for (const Node *node : selection) { | |
| for (const Node *node : editor_selection->get_full_selected_node_list()) { |
The list is no longer copied (I think?), but it should be fine in this case.
Contributor
Author
There was a problem hiding this comment.
Updated.
The method comments in editor_data.h still read "Returns a copy...", but the actual code uses ObjectDB::get_instance<Node>(nid). I will update those comments in PR #119617.
KoBeWi
approved these changes
Jun 2, 2026
EdwardChanCH
force-pushed
the
fix_open_doc_selection
branch
from
81765fd to
e3bb264
Compare
EdwardChanCH
force-pushed
the
fix_open_doc_selection
branch
from
e3bb264 to
d9c53f2
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119907
Note: Split from #119617. Can be merged separately.
Changes:
Video:
fix_open_doc_selection.mp4