Fix "Rename" and "Batch Rename" ignoring non-top-level nodes and editing foreign nodes

[EdwardChanCH]

Closes #119593
Closes #119645

Related PRs:

• Fix "Open Documentation" ignoring non-top-level nodes #119908
• Fix "Change Type" ignoring non-top-level nodes and editing foreign nodes #119909
• Fix "Move Up/Down" editing foreign nodes #119910

Changes:

• "Rename" now correctly appears when right-clicking the root node of an inherited scene.
  • Had to untangle some nested conditions, but there should be no unlisted changes.
• "Rename" and "Batch Rename" are now correctly hidden when any yellow foreign node is selected.
• "Alert!" pop-up now correctly shows up when trying to rename yellow foreign nodes with F2.

[EdwardChanCH]

In the future, a follow-up PR could sync the Rename button (shown/hidden) with the color of the node name (white/yellow):

godot/editor/scene/scene_tree_editor.cpp

Lines 466 to 469 in 3bfa50f

	} else if (p_part_of_subscene) {
	if (valid_types.is_empty()) {
	_set_item_custom_color(p_item, get_theme_color(SNAME("warning_color"), EditorStringName(Editor)));
	}

[EdwardChanCH]

Need more time for this fix, the rabbit hole gets deeper and deeper...

[ajreckof]

Hi #74236 seems unrelated to the other issue except for the fact that they are in the same part of the editor if so please make a separate PR to fix it

[EdwardChanCH]

Hi #74236 seems unrelated to the other issue except for the fact that they are in the same part of the editor if so please make a separate PR to fix it

It is related, unfortunately. "Change Type" (along with the others) requires the new _validate_no_foreign_selected() to prevent editing foreign child nodes in the selection.

But I plan to split this into separate PRs (one per issue) once I get everything fixed and tested (would require duplicating some shared changes). Thanks for the reminder though.

		case TOOL_CHANGE_TYPE: {
			if (!profile_allow_editing) {
				break;
			}

			List<Node *> full_selection = editor_selection->get_full_selected_node_list();

			if (!_validate_no_foreign_selected(full_selection)) { // New
				break;
			}

			if (!_validate_no_instance_selected(full_selection)) { // New
				break;
			}

[EdwardChanCH]

Triple checked all the related code and locally tested all the new code, finally!
Will split this into smaller, more focused PRs.

Bug triage results:

• Confusing selection with full_selection in scene_tree_dock.cpp.
• Misusing get_top_selected_node_list() for get_full_selected_node_list().
• Incorrect usage of _validate_no_foreign(), _validate_no_instance() to check full_selection.

Split PRs:

• Fix "Open Documentation" ignoring non-top-level nodes #119908
• Fix "Change Type" ignoring non-top-level nodes and editing foreign nodes #119909
• Fix "Move Up/Down" editing foreign nodes #119910

[EdwardChanCH]

Cleaned up the code and undid some unnecessary changes. Ready for review!

[EdwardChanCH]

Updated comments. In sync with #119909 and #119910.

[EdwardChanCH]

Rebased after #119909.

• Cleaned up duplicated editor_selection->get_top_selected_node_list() calls from #119909.
• Acted on comments about renaming variables to selection = editor_selection->get_top_selected_node_list().