Fix AnimationNode's branching by custom timeline usage#119980
Merged
Conversation
akien-mga
approved these changes
Jun 2, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
AnimationNodeAnimation's custom timeline processing logic compatible withAnimationMixer#119871Since the default value for
stretch_time_scaleistrue, the code would check it even whenuse_custom_timelinewas disabled, causing it to use an uninitializedtimeline_lengthin the speed calculation. Fixed the check. cc @chocola-mintSince the default value for
timeline_lengthis 1.0 seconds, issues arise with animations that do not exactly 1.0 second duration. I didn’t notice this in #119871 test because the test used animations with 1.0 seconds duration. If we’re creating tests, we should include animations that do not 1.0 seconds duration.Additional information