Skip to content

constraint jacobian update for io.put_data#1255

Merged
thowell merged 1 commit intogoogle-deepmind:mainfrom
thowell:io_put_data_efc
Mar 24, 2026
Merged

constraint jacobian update for io.put_data#1255
thowell merged 1 commit intogoogle-deepmind:mainfrom
thowell:io_put_data_efc

Conversation

@thowell
Copy link
Collaborator

@thowell thowell commented Mar 22, 2026

refactor io.put_data for constraint jacobian

  • utilize the mjData instance's sparse representation instead of constructing a dense representation to populate Data fields
  • efc_J (dense) is not always shape (nefc, nv) -- it can be overallocated. this update should support cases where efc_J has less active constraints than memory allocated for constraints.

@thowell thowell force-pushed the io_put_data_efc branch 2 times, most recently from 7bddb28 to 6c392b0 Compare March 23, 2026 12:35
@thowell thowell requested a review from adenzler-nvidia March 23, 2026 12:36
Copy link
Collaborator

@erikfrey erikfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite following a few of these changes - they seem neither related to the PR description nor any relevant changes I can find in #1241 - can you provide a bit more context so I understand what I'm reviewing?

Copy link
Collaborator

@erikfrey erikfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@thowell thowell merged commit 573d406 into google-deepmind:main Mar 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants