Add ORAchk to the Oracle Toolkit (#35) #220

jkstill · 2025-03-06T20:29:12Z

Change Description:

The check-oracle.sh script was added to the oracle-toolkit.

This will allow installing, running and uninstalling orachk.

Solution Overview:

The following files were created to extract and install orachk from the AHF Bundle, run orachk, and uninstall orachk.

check-oracle.sh
- the main user script
ansible files
- check-oracle-vars.yml
- check-oracle.yml
files copied to the target server to run orachk
- run-orachk.sh
- orachk.env

Test Commands:

Test Prep:

Download the AHF bundle and copy to the Software Media Bucket.

For Pythian Internal Testing, the two most recent AHF zip files are already copied to the SW Media Bucket

Detailed output examples are available in the User Guide.

Install

./check-oracle.sh  --ahf-install \
      --ora-swlib-bucket gs://pythian-gto-oracle-software \
      --oracle-sid ORCL \
      --oracle-server jkstill-orachk-19c-patch \
      --ahf-dir AHF \
      --ahf-file AHF-LINUX_v25.1.0.zip

Run

./check-oracle.sh  --run-orachk \
      --oracle-sid ORCL \
      --oracle-server jkstill-orachk-19c-patch

Uninstall

./check-oracle.sh  --ahf-uninstall \
      --oracle-sid ORCL \
      --oracle-server jkstill-orachk-19c-patch

Install and Run

./check-oracle.sh  --ahf-install \
        --ora-swlib-bucket gs://pythian-gto-oracle-software \
        --oracle-sid ORCL \
        --oracle-server jkstill-orachk-19c-patch \
        --ahf-dir AHF \
        --ahf-file AHF-LINUX_v25.1.0.zip \
        --run-orachk

Expected Result

An orachk report zip file will be placed in the local /tmp/ directory.,

The name of the file will be shown in when check-oracle.sh --run-orachk is used.

The check-oracle.sh script was added to the oracle-toolkit. This will allow installing, running and uninstallint orachk. Solution Overview: The following files were created to extract and install orachk from the AHF Bundle, run orachk, and uninstall orachk. check-oracle.sh the main user script ansible files check-oracle-vars.yml check-oracle.yml files copied to the target server to run orachk run-orachk.sh orachk.env Test Commands: Test Prep: Download the AHF bundle and copy to the Software Media Bucket. For Pythian Internal Testing, the two most recent AHF zip files are already copied to the SW Media Bucket Detailed output examples are available in the User Guide. Install ./check-oracle.sh --ahf-install \ --ora-swlib-bucket gs://pythian-gto-oracle-software \ --oracle-sid ORCL \ --oracle-server jkstill-orachk-19c-patch \ --ahf-dir AHF \ --ahf-file AHF-LINUX_v25.1.0.zip Run ./check-oracle.sh --run-orachk \ --oracle-sid ORCL \ --oracle-server jkstill-orachk-19c-patch Uninstall ./check-oracle.sh --ahf-uninstall \ --oracle-sid ORCL \ --oracle-server jkstill-orachk-19c-patch Install and Run ./check-oracle.sh --ahf-install \ --ora-swlib-bucket gs://pythian-gto-oracle-software \ --oracle-sid ORCL \ --oracle-server jkstill-orachk-19c-patch \ --ahf-dir AHF \ --ahf-file AHF-LINUX_v25.1.0.zip \ --run-orachk Expected Result An orachk report zip file will be placed in the local /tmp/ directory., The name of the file will be shown in when check-oracle.sh --run-orachk is used.

google-oss-prow · 2025-03-06T20:29:22Z

Hi @jkstill. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jkstill · 2025-03-06T20:30:27Z

Complete list of logs for testing orachk with 12cR2, 19c and 21c

oratk-57-orachk orachk-12cR2-install-and-run
oratk-57-orachk orachk-12cR2-run
oratk-57-orachk orachk-12cR2-install
oratk-57-orachk orachk-12cR2-uninstall
oratk-57-orachk orachk-21c-uninstall
oratk-57-orachk orachk-21c-run
oratk-57-orachk orachk-21c-install
oratk-57-orachk orachk-21c-install-and-run
oratk-57-orachk orachk-19c-uninstall
oratk-57-orachk orachk-19c-run
oratk-57-orachk orachk-19c-install
oratk-57-orachk orachk-19c-install-and-run

jkstill · 2025-03-11T14:37:08Z

/ok-to-test

jkstill · 2025-03-11T14:59:59Z

/retest

mfielding · 2025-03-11T16:16:00Z

/ok-to-test

mfielding

I think this change is reverting unrelated changes by mistake; can you do through the "files changed" to make sure they're just the ones we intend for this change? Thanks!

…7-orachk Merge in old commits that were recently merged into oracle-toolkit

mfielding · 2025-03-14T15:10:24Z

/retest

mfielding · 2025-03-14T15:12:17Z

presubmit_tests/test-pr-poc.sh

@@ -46,7 +46,7 @@ fi

 # run the install script
 ./install-oracle.sh --ora-swlib-bucket gs://bmaas-testing-oracle-software \
--instance-ssh-user ansible1 --instance-ssh-key /etc/files_needed_for_tk/id_rsa_bms_tk_key \


I think this was changed unintentionally (and is causing presubmit tests to fail)

That file is no longer in the PR. There had been a permissions change in an earlier commit by another dev, though I do not know why it appeared as changed here.

mfielding · 2025-03-14T15:13:05Z

roles/common/defaults/main.yml

@@ -445,6 +445,22 @@ gi_patches:
  - { category: "RU", base: "21.3.0.0.0", release: "21.16.0.0.0", patchnum: "36990664", patchfile: "p36990664_210000_Linux-x86-64.zip", patch_subdir: "/", prereq_check: false, method: "opatchauto apply", ocm: false, upgrade: false, md5sum: "N1p/HLEg+UFYAr04loujqg==" }
  - { category: "RU", base: "21.3.0.0.0", release: "21.17.0.0.0", patchnum: "37349593", patchfile: "p37349593_210000_Linux-x86-64.zip", patch_subdir: "/", prereq_check: false, method: "opatchauto apply", ocm: false, upgrade: false, md5sum: "Mt0Bw+IPKqoKh31YkneCrg==" }

+# 21c GRID RU - 21.4 and 21.7 are available only via SR


Here too; do we intend to modify patch definitions for 21.3 here?

Not sure why that was changed here, likely a mistake. Reverted.

mfielding · 2025-03-14T15:23:50Z

docs/user-guide.md

+```text
+
+
+$ ./check-oracle-test.sh install-and-run


This is coming as rather long: 300+ lines of sample output. Can we skip some of the intermediate output just to show the command and some key results, so people don't have to scroll down too far through the user guide?

examples shortened

mfielding · 2025-03-14T15:24:56Z

docs/user-guide.md

+changed: [ora-db-server-orachk-19c-patch]
+
+TASK [Create AHF directory] ************************************************************************************************************************************************************************************
+skipping: [ora-db-server-orachk-19c-patch]


Ahh, since we're talking about keeping output trip, I think we have ansible configured not to output the "skipping" lines when running install-oracle.sh. Would it make sense to do the same here?

'skipping' no longer displayed

mfielding · 2025-03-14T15:25:40Z

manage_devices_on_vm.sh

I think this file was added by mistake.

Agreed, not sure why this is appearing here.

mfielding · 2025-03-14T15:35:49Z

run-orachk.sh

+. $orachk_env_file
+
+# use of undeclared variables is fatal
+set -u


Maybe 'set -e' too, to make errors in subcommands fatal too?

The scrips that had 'set -u' no longer exist.

mfielding · 2025-03-14T15:40:59Z

orachk.sh

Just to avoid cluttering up the top-level directory too much, can we put the internal functionality into a subdirectory, and leave just the user-exposed check-oracle.sh at the top level?

run-orachk.sh

mfielding · 2025-03-14T15:46:40Z

run-orachk.sh

Most of the logic here seems to be to validate preqresuities and set environment variables for orachk itself. Assuming we intend only to run form ansible, and that the playbook already satisfies the prerequisites, is it possible for the playbook to directly run ${ORACHK_BASE}/bin/${CHK_EXE_NAME} ?

run-check.sh and orachk.sh removed, and their functionality moved to ansible files.

mfielding · 2025-03-14T15:47:57Z

check-oracle.sh

Do you mind running these shell scripts through a linter like shellcheck? It has a bunch of lint-style warnings around quoting and the like.

The only remaining shell script is check-oracle.sh, and I have run it through shellcheck, and made any modifications that were appropriate.

mfielding · 2025-03-14T22:38:59Z

check-oracle-vars.yml

+# Default is to NOT uninstall AHF
+uninstall_ahf: false
+# default is to NOT run orachk
+run_orachk: false


Just had a thought here: check-oracle says it's used to run orachk, but here the default is not to run it. So I must be missing something here.

We do not uninstall/install AHF if already installed - that's all it is.
If AHF has been uninstalled, then the install will take place.

…n changed

…time examples

jkstill · 2025-03-24T23:00:03Z

Logs of all runs made following requested changes:

mfielding

I wasn't able to get this to complete, but I did manage to get fairly far and here are a few comments related to the hiccups I saw.

mfielding · 2025-03-25T18:20:17Z

check-oracle.sh

+[[ -z $ORACLE_SERVER ]] && { echo "please specify --oracle-server"; exit 1; }
+[[ -z $ORACLE_SID ]] && { echo "please specify --oracle-sid"; exit 1; }
+
+INVENTORY_FILE=inventory_files/inventory_${ORACLE_SERVER}_${ORACLE_SID}


If --oracle-server and --oracle-sid are just used to generate an inventory file, I think it would be better to accept invenotry_file directly, just like cleanup-oracle.sh does today. Why? In my RAC install, the inventory file has a different naming convention. When installing, we use --db-name and --instance-ip-addr rather than oracle-sid and oracle-server, so can be confusing here.

@mfielding While I can add a parameter --inventory-file, the --oracle-sid is not just to get the name of the inventory file.

--oracle-server and be renamed to --instance-ip-addr

--oracle-sid can be renamed to --db-name, but will still be required, as the value must be specified on the orachk command line.

Edit: --db-name is only required to run orachk, not to install or uninstall

mfielding · 2025-03-25T18:21:12Z

check-oracle.sh

+            shift
+            ;;
+
+        --ahf-install)


If no command is specified, this script exits with success and no output at all. It would be better to show an error in this case.

Something here does not seem right.

When I run without any options, I get this:

$ ./check-oracle.sh please specify --oracle-server

When run with --ahf-install

$ ./check-oracle.sh --ahf-install please specify --oracle-server

I think it would probably be good to include the help message here, but, there is output.

Can you verify that check-oracle.sh is correct?

What I see in google-toolkit-for-oracle in rel/oratk-57-orachk

$ sha256sum check-oracle.sh 1ffdb2c72f52ce073f8a7b0c6cc3309653adc9226cef072a4faf06174f9a0928 check-oracle.sh

In my case, I'm saw the error message and passed --oracle-server as requested (but no command). And I got success and blank output.

mfielding · 2025-03-25T18:23:53Z

check-oracle.sh

+while true
+do
+
+    case "$1" in


Can I ask for a --debug parameter like install-oracle.sh does, which adds verbosity to the ansible-playbook command? Maybe even an --extra-vars to pass extra stuff to ansible if needed?

mfielding · 2025-03-25T18:25:06Z

check-oracle.yml

+            state: directory
+            mode: "0700"
+
+        - name: Copy AHF file from Google Storage


If this file doesn't exist, I get a success here, and an undecipherable error later. If the file can't be found, can we fail with an obvious error?

TASK [Copy AHF file from Google Storage] ***********************************************************************************************************************************************************************************************************************************************************************************
ok: [mfielding-ora122-node2]

TASK [Unzip AHF file] ******************************************************************************************************************************************************************************************************************************************************************************************************
fatal: [mfielding-ora122-node2]: FAILED! => {"changed": false, "msg": "Failed to find handler for "/u01/AHF". Make sure the required command to extract the file is installed.\nCommand "/bin/gtar" could not handle archive: Unable to list files in the archive: tar (child): /u01/AHF: Cannot read: Is a directory\ntar (child): At beginning of tape, quitting now\ntar (child): Error is not recoverable: exiting now\ntar (grandchild): bzip2: Cannot exec: No such file or directory\ntar (grandchild): Error is not recoverable: exiting now\n/bin/gtar: Child returned status 2\n/bin/gtar: Error is not recoverable: exiting now\n\nCommand "/bin/gtar" could not handle archive: Unable to list files in the archive: /bin/gtar: /u01/AHF: Cannot read: Is a directory\n/bin/gtar: At beginning of tape, quitting now\n/bin/gtar: Error is not recoverable: exiting now\n\nCommand "/bin/gtar" could not handle archive: Unable to list files in the archive: tar (child): /u01/AHF: Cannot read: Is a directory\ntar (child): At beginning of tape, quitting now\ntar (child): Error is not recoverable: exiting now\n\ngzip: stdin: unexpected end of file\n/bin/gtar: Child returned status 2\n/bin/gtar: Error is not recoverable: exiting now\n\nCommand "/bin/unzip" could not handle archive: unzip: cannot find or open /u01/AHF, /u01/AHF.zip or /u01/AHF.ZIP.\n\nCommand "/bin/gtar" could not handle archive: Unable to list files in the archive: tar (child): /u01/AHF: Cannot read: Is a directory\ntar (child): At beginning of tape, quitting now\ntar (child): Error is not recoverable: exiting now\ntar (grandchild): zstd: Cannot exec: No such file or directory\ntar (grandchild): Error is not recoverable: exiting now\n/bin/gtar: Child returned status 2\n/bin/gtar: Error is not recoverable: exiting now\n\nCommand "/bin/gtar" could not handle archive: Unable to list files in the archive: tar (child): /u01/AHF: Cannot read: Is a directory\ntar (child): At beginning of tape, quitting now\ntar (child): Error is not recoverable: exiting now\nxz: (stdin): File format not recognized\n/bin/gtar: Child returned status 2\n/bin/gtar: Error is not recoverable: exiting now\n"}

Still not working for me, even with the latest version of the code. It seems /u01/AHF is empty:

[mfielding_google_com@mfielding-ora122-node1 ~]$ sudo ls -al /u01/AHF
total 0
drwx------ 2 root root 6 Mar 25 18:17 .
drwxr-xr-x 6 root oinstall 57 Mar 25 18:17 ..

And then the unzip fails with a cryptic error (pasted last comment) that seems to be related to unarchive trying to detect the archive format.

--debug output attached in case it's useful: https://gist.github.com/mfielding/d932a159ae5a50cedce458375f8843f1

mfielding · 2025-03-25T18:27:29Z

check-oracle.sh

+
+ORACLE_SERVER=''
+AHF_DIR='AHF'
+AHF_FILE=''


As with oracle_server, if we're using ora-swlib-bucket and ahf-file only to generate a GCS path to pull the AHF zipfile, I'd prefer just to accept a simple --ahf-location=gs://bucket/file/location/AHF.zip parameter, and validate that it starts with gs:// and that it exists.

mfielding · 2025-03-25T18:28:21Z

check-oracle.sh

+    exit 1
+fi
+
+# set to 'echo ' to only dislay commands


To echo commands, I jsut run bash -x check.oracle.sh ...
So if even just for consistency with our other shell scripts, can we remove this debug reference?

however, not yet pushed to repo.

mfielding · 2025-03-25T18:31:26Z

check-oracle.yml

+            state: present
+
+        - name: Run AHF setup
+          shell: yes 'Y' | ./ahf_setup -extract -notfasetup


Does this run AHF in daemon mode? If so, I'd prefere standalone, if just that it's one less thing to clean up. The intent here is for a one-off anyway.

AHF is not fully installed. The method used is the one documented that allows running ORAchk in standalone mode.
check.oracle --ahf-uninstall removes the AHF installation.
What is left is the zip file and log file created by orachk.

I'm not sure why this would be considered a one off. ORAchk may be run repeatedly to determine if any remediation efforts were effective.

mfielding · 2025-03-25T18:35:38Z

check-oracle.yml

+            mode: "0700"
+
+        - name: Copy AHF file from Google Storage
+          shell: gsutil cp {{ ORA_SWLIB_AHF_FILENAME }} {{ ahf_extract_path }}


I get an error here:

" File \"/usr/lib64/google-cloud-sdk/platform/gsutil/gslib/cloud_api_delegator.py\", line 123, in _GetApi", " self._LoadApi(provider, api_selector)", " File \"/usr/lib64/google-cloud-sdk/platform/gsutil/gslib/cloud_api_delegator.py\", line 141, in _LoadApi", " self.api_map[ApiMapConstants.API_MAP][provider][api_selector](", " File \"/usr/lib64/google-cloud-sdk/platform/gsutil/gslib/gcs_json_api.py\", line 242, in __init__", " SetUpJsonCredentialsAndCache(self, logger, credentials=credentials)", " File \"/usr/lib64/google-cloud-sdk/platform/gsutil/gslib/gcs_json_credentials.py\", line 218, in SetUpJsonCredentialsAndCache", " api.credentials = (credentials or _CheckAndGetCredentials(logger) or", " ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^", " File \"/usr/lib64/google-cloud-sdk/platform/gsutil/gslib/gcs_json_credentials.py\", line 301, in _CheckAndGetCredentials", " gce_creds = _GetGceCreds()", " ^^^^^^^^^^^^^^", " File \"/usr/lib64/google-cloud-sdk/platform/gsutil/gslib/gcs_json_credentials.py\", line 464, in _GetGceCreds", " return credentials_lib.GceAssertionCredentials(", " ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^", " File \"/usr/lib64/google-cloud-sdk/platform/gsutil/third_party/apitools/apitools/base/py/credentials_lib.py\", line 263, in __init__", " scopes = cached_scopes or self._ScopesFromMetadataServer(scopes)", " ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^", " File \"/usr/lib64/google-cloud-sdk/platform/gsutil/third_party/apitools/apitools/base/py/credentials_lib.py\", line 339, in _ScopesFromMetadataServer", " raise exceptions.ResourceUnavailableError(", "apitools.base.py.exceptions.ResourceUnavailableError: GCE credentials requested outside a GCE instance"

I'd suggest using the same mechanism we use for install-oracle.sh: running the GCS copy from the control node: https://github.com/google/oracle-toolkit/blob/633e4e61ad3f0a35ebf80e1065066bf547f53204/roles/swlib/tasks/gcscopy.yml

Can you share the command lines you are using? Otherwise I just have to guess at what the command options are being used.

(with some hacked up code to use my inventory file)
./check-oracle.sh --ahf-install --inventory-file inventory_files/inventory_new_RAC --ora-swlib-bucket gs://my-
oracle-software --ahf-file AHF-LINUX_v25.2.2.zip

But I think the key point is that we may not be able to rely on commands like gsutil working on the DB node.

… testing

jkstill · 2025-03-27T00:34:55Z

Changes to check-oracle.sh

--oracle-sid is now --db-name
--oracle-server changed to --instance-ip-addr
- server name may be used here as well
--extra-vars option added
--debug option added
--ahf-location added
- swlib options removed
tests in check-oracle.yml to validate files and content
- /etc/oratab
- ORAchk output log, used to get ORAchk report zip file
- the ORAchk zip file
- error messages display should these fail

Options to install

example 1:

./check-oracle.sh \
  --ahf-install \
  --db-name <your-database-name> \
  --instance-ip-addr <your-instance-ip-address|server-name> \
  --ahf-location <path-to-ahf-zip-file>

example 2:

./check-oracle.sh \
  --ahf-install \
  --inventory-file <path-to-inventory-file> \
  --ahf-location <path-to-ahf-zip-file>

Options to run

The minimum required options to run:

example 1:

./check-oracle.sh \
  --run-orachk \
  --db-name <your-database-name> \
  --instance-ip-addr <your-instance-ip-address|server-name>

example 2:

./check-oracle.sh \
  --run-orachk \
  --db-name <your-database-name> \
  --inventory-file <path-to-inventory-file>

jkstill · 2025-03-27T00:39:04Z

Gists from the most recent tests.

These tests are using expedited testing, which entails the use of a dummy script to replace orachk for testing purposes.
ie. orachk will run in seconds rather than minutes, which is useful for testing logic.

This is done by adding --extra-vars "expedited_testing=true" to the command line

Tests can then be run in regular mode once changes are accepted.

'oratk-57-orachk no options'
'oratk-57-orachk fail due to invalid ahf'
'oratk-57-orachk succeed with valid ahf'
'oratk-57-orachk fail due to invalie db-name'
'oratk-57-orachk succeed with valid db-name'
'oratk-57-orachk succeed - lookup inventory file via ip address'
'oratk-57-orachk succeed - lookup inventory file with hostname'
'oratk-57-orachk succeed - uninstall'

mfielding

Unfortunately I'm still not able to get through the install stage; I attached a gist in the comments with my full --debug output in case it's useful.

mfielding · 2025-03-27T16:11:43Z

check-oracle.sh

+help () {
+
+    echo -e "\tUsage: $(basename "$0")"
+    echo "${GETOPT_MANDATORY}" | sed 's/,/\n/g' | sed 's/:/ <value>/' | sed 's/\(.\+\)/\t --\1/'


I do like the autogeneration of usage, but when I run it, I don't see --install-ahf at all:

$ bash ./check-oracle.sh --inventory-file inventory_files/inventory_new_RAC
Usage: check-oracle.sh
--instance-ip-addr
[ --extra-vars ]
[ --ahf-location ]
[ --db-name ]
[ --inventory-file ]
[ --ahf-install ]
[ --ahf-uninstall ]
[ --run-orachk ]
[ --help ]
[ --debug ]

--ahf-install and --run-orachk may be combined to install and run
--extra-vars is used to pass extra ansible vars
example: --extra-vars var1=val1 var2=val2 ...

mfielding · 2025-03-27T16:22:42Z

check-oracle.yml

+            state: directory
+            mode: "0700"
+
+        - name: Copy AHF file from Google Storage


Still not working for me, even with the latest version of the code. It seems /u01/AHF is empty:

[mfielding_google_com@mfielding-ora122-node1 ~]$ sudo ls -al /u01/AHF
total 0
drwx------ 2 root root 6 Mar 25 18:17 .
drwxr-xr-x 6 root oinstall 57 Mar 25 18:17 ..

And then the unzip fails with a cryptic error (pasted last comment) that seems to be related to unarchive trying to detect the archive format.

--debug output attached in case it's useful: https://gist.github.com/mfielding/d932a159ae5a50cedce458375f8843f1

mfielding · 2025-03-28T20:18:57Z

check-oracle.yml

+            - name: Download AHF file from Google Storage to the ansible control node.
+              local_action: 
+                module: command
+                cmd: "gsutil cp {{ AHF_LOCATION }} {{ local_ahf_path }}"


In my case, ansible is running this as root, and causing issues with gsutil:

mfielding_google_com@mfielding-ora122-control:~/git/orachk$ ls -l /tmp/AHF* -rw-r--r-- 1 root root 311141407 Mar 28 20:11 /tmp/AHF-LINUX_v25.2.2.zip TASK [Download AHF file from Google Storage to the ansible control node.] *********************************************************************************************************** changed: [mfielding-ora122-node2 -> localhost] fatal: [mfielding-ora122-node1 -> localhost]: FAILED! => {"changed": false, "cmd": ["gsutil", "cp", "gs://gcp-oracle-software/AHF/AHF-LINUX_v25.2.2.zip", "/tmp/AHF-LINUX_v25.2.2.zip"], "delta": "0:00:08.449122", "end": "2025-03-28 20:11:31.968966", "msg": "non-zero return code", "rc": 1, "start": "2025-03-28 20:11:23.519844", "stderr": "Copying gs://gcp-oracle-software/AHF/AHF-LINUX_v25.2.2.zip...\n/ [0 files][ 0.0 B/296.7 MiB] \r-\r- [0 files][ 33.8 MiB/296.7 MiB] \r\\\r|\r| [0 files][ 92.8 MiB/296.7 MiB] \r/\r/ [0 files][151.3 MiB/296.7 MiB] \r-\r\\\r\\ [0 files][208.8 MiB/296.7 MiB] \r|\r/\r/ [0 files][266.3 MiB/296.7 MiB] \r-\rOSError: No such file or directory.", "stderr_lines": ["Copying gs://gcp-oracle-software/AHF/AHF-LINUX_v25.2.2.zip...", "/ [0 files][ 0.0 B/296.7 MiB] ", "-", "- [0 files][ 33.8 MiB/296.7 MiB] ", "\\", "|", "| [0 files][ 92.8 MiB/296.7 MiB] ", "/", "/ [0 files][151.3 MiB/296.7 MiB] ", "-", "\\", "\\ [0 files][208.8 MiB/296.7 MiB] ", "|", "/", "/ [0 files][266.3 MiB/296.7 MiB] ", "-", "OSError: No such file or directory."], "stdout": "", "stdout_lines": []}

Not sure what's going on here; one thing to try might be to use gcloud storage cp instead of gsutil cp; it's more modern and has better error checking.

Copying to the localhost first and then copying to the remote does complicate things.

The 'become: true' is now being used only where necessary, so the file will be owned by the current user.

Now using the ansible stat module to check for the file, it just has to exist.

Also switched to gcloud storage cp

mfielding · 2025-03-28T20:20:38Z

check-oracle.yml

+            - name: Download AHF file from Google Storage to the ansible control node.
+              local_action: 
+                module: command
+                cmd: "gsutil cp {{ AHF_LOCATION }} {{ local_ahf_path }}"


Separately, can we fix the quoting here? I suggest:
cmd: gsutil cp "{{ AHF_LOCATION }}" "{{ local_ahf_path }}"
(or, even better, the equivalent gcloud storage cp command)
Among other things, it will help us detect if one of these variables is empty.

Now using gcloud storage cp "{{ AHF_LOCATION }}" "{{ local_ahf_path }}"

…g "become: true" only where necesssary

mfielding · 2025-04-02T23:14:24Z

check-oracle.yml

+    - block:
+        - name: Create AHF directory
+          file:
+            path: "{{ ahf_extract_path }}"


This is failing for me, on a brand new install:

fatal: [mfielding-ora122-node1]: FAILED! => {"changed": false, "msg": "There was an issue creating /u01/AHF as requested: [Errno 13] Permission denied: b'/u01/AHF'", "path": "/u01/AHF"}

ls -ld /u01

drwxr-xr-x 4 root oinstall 32 Apr 2 22:02 /u01

mfielding · 2025-04-02T23:14:33Z

check-oracle.yml

+
+        - name: Create ORAchk directory
+          file:
+            path: "{{ orachk_script_dir }}"


This will probably fail for me too.

…now removes AHF and orachk directories

mfielding

Thanks for the fixes. Still getting permission errors, sadly.

mfielding · 2025-04-03T17:13:22Z

check-oracle.yml

+            msg: "Could not locate ORAchk report file {{ ORACHK_RPT_FILE }}"
+          when: not orachk_rpt_location.stat.exists
+
+        - name: Fetch the ORAchk zipfile


I'm getting permission errors here too:

TASK [Fetch the ORAchk zipfile] ***************************************************************************************
fatal: [mfielding-ora122-node1]: FAILED! => {"changed": false, "msg": "file is not readable: /opt/oracle.ahf/data/mfielding-ora122-node1/orachk/orachk_mfielding-ora122-node1_040325_17063.zip"}

$ sudo ls -l /opt/oracle.ahf/data/mfielding-ora122-node1/orachk/orachk_mfielding-ora122-node1_040325_17063.zip
-r--r----- 1 root root 3902854 Apr 3 17:11 /opt/oracle.ahf/data/mfielding-ora122-node1/orachk/orachk_mfielding-ora122-node1_040325_17063.zip

I had thought it might be necessary to use root to get this file, but it was not needed in my environment for some reason.
I will change that, and set ownership appropriately for the orachk zip file.

…r the local reports. added specific name to local tmp file and code to remove when no longer needed

mfielding

Looks good; with the latest changes everything's working for me.

google-oss-prow · 2025-04-04T15:34:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkstill, mfielding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mfielding]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow bot added needs-ok-to-test size/XXL labels Mar 6, 2025

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Mar 11, 2025

jkstill requested a review from mfielding March 11, 2025 14:59

mfielding reviewed Mar 11, 2025

View reviewed changes

Merge remote-tracking branch 'oracle-toolkit/master' into rel/oratk-5…

1d1714c

…7-orachk Merge in old commits that were recently merged into oracle-toolkit

google-oss-prow bot added size/XL and removed size/XXL labels Mar 13, 2025

mfielding reviewed Mar 14, 2025

View reviewed changes

jkstill added 2 commits March 14, 2025 10:32

Remove unintended changes to manage_devices_on_vm.sh

27fb68c

Remove unintended changes to presubmit_tests/test-pr-poc.sh

c652c40

mfielding reviewed Mar 14, 2025

View reviewed changes

jkstill added 8 commits March 24, 2025 13:20

removed orachk.sh, run-orack.sh. moved the tasks to ansible

da19496

Merge branch 'master' into rel/oratk-57-orachk

329904c

removed check-oracle-vars.yml - no longer used

f9fc032

reverted master:roles/common/defaults/main.yml. Unsure why it had bee…

928d74a

…n changed

set export ANSIBLE_DISPLAY_SKIPPED_HOSTS=false. Shorten up orachk run…

f0fac13

…time examples

shellcheck

cd8eff7

quoted $0

43285fc

added copyright

0731637

mfielding reviewed Mar 25, 2025

View reviewed changes

jkstill added 4 commits March 26, 2025 10:43

working on PR changes

7480284

continued work on PR requested changes

dd91795

further changes as per PR requests. also added facility for expedited…

6fa6ecc

… testing

updated orachk install, run and uninstall docs

52ab35f

mfielding reviewed Mar 27, 2025

View reviewed changes

jkstill added 3 commits March 27, 2025 15:34

use a gsutil to get AHF file to local host, then copy to remote

a2ad6df

removed unnecessary comments

59f1184

minor adjustments

64f9cb6

mfielding reviewed Mar 28, 2025

View reviewed changes

now using ansible stat to check for file existence on localhost. usin…

8ebb803

…g "become: true" only where necesssary

jkstill force-pushed the rel/oratk-57-orachk branch from 04b3213 to 8ebb803 Compare March 28, 2025 22:12

jkstill added 4 commits March 28, 2025 15:35

change from gsutil cp to gcloud storage cp

bda6d83

fixed quoting for gcloud storage cp

2d0886a

fixed assignment operator ${ORACLE_SID:="NOOP"} was backwards with "=:"

e43a8b3

use become: to fetch the file due to permissions

2cffcb4

mfielding reviewed Apr 2, 2025

View reviewed changes

jkstill added 2 commits April 3, 2025 09:48

Merge branch 'master' into rel/oratk-57-orachk

5bf4efa

updated to use become: true|false where explicitly needed. uninstall …

6d9ed2b

…now removes AHF and orachk directories

mfielding reviewed Apr 3, 2025

View reviewed changes

added become: true for fetching orachk report. create /tmp/orachk/ fo…

028aeb6

…r the local reports. added specific name to local tmp file and code to remove when no longer needed

mfielding approved these changes Apr 4, 2025

View reviewed changes

google-oss-prow bot assigned mfielding Apr 4, 2025

google-oss-prow bot added the lgtm label Apr 4, 2025

google-oss-prow bot added the approved label Apr 4, 2025

mfielding merged commit 10aab83 into google:master Apr 4, 2025
2 checks passed

jkstill deleted the rel/oratk-57-orachk branch April 4, 2025 15:53

Add ORAchk to the Oracle Toolkit (#35) #220

Add ORAchk to the Oracle Toolkit (#35) #220

Conversation

jkstill commented Mar 6, 2025 • edited Loading

Change Description:

Solution Overview:

Test Commands:

Test Prep:

Install

Run

Uninstall

Install and Run

Expected Result

google-oss-prow bot commented Mar 6, 2025

jkstill commented Mar 6, 2025

jkstill commented Mar 11, 2025

jkstill commented Mar 11, 2025

mfielding commented Mar 11, 2025

mfielding left a comment

Choose a reason for hiding this comment

mfielding commented Mar 14, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkstill commented Mar 24, 2025

mfielding left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkstill Mar 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkstill commented Mar 27, 2025

Changes to check-oracle.sh

Options to install

Options to run

jkstill commented Mar 27, 2025

mfielding left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ls -ld /u01

Choose a reason for hiding this comment

mfielding left a comment

Choose a reason for hiding this comment

jkstill commented Mar 6, 2025 •

edited

Loading

jkstill Mar 26, 2025 •

edited

Loading