docs: Add Banner Configuration#3274
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the existing migration banner into a more flexible and configurable general announcement banner system. The changes include introducing a configuration object for banner content, updating CSS for a responsive layout with a close button, and implementing session-based dismissal logic. Feedback provided highlights several areas for improvement: supporting internationalization by moving hardcoded strings to the Hugo configuration, restoring the sticky positioning of the banner, including the banner ID in the storage key to handle updates correctly, and addressing a potential XSS vulnerability by avoiding the use of innerHTML for content injection.
dishaprakash
added
the
docs: deploy-preview
dishaprakash
added
the
priority: p1
github-actions
Bot
removed
the
docs: deploy-preview
Contributor
|
🚀 Cloudflare Preview Ready! 🔎 View Preview: https://pr-3274.toolbox-docs-6xc.pages.dev (Note: Subsequent pushes to this PR will automatically update the preview at this same URL) |
averikitsch
added
the
do not merge
Yuan325
removed
the
do not merge
Yuan325
approved these changes
Jun 24, 2026
Contributor
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user. Before merging, please alter the title, message, linkText and linkURL --------- Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 41dfcb7
github-actions Bot
pushed a commit
to rodineyw/mcp-toolbox
that referenced
this pull request
Jun 25, 2026
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user. Before merging, please alter the title, message, linkText and linkURL --------- Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 41dfcb7
github-actions Bot
pushed a commit
to Jaleel-zhu/genai-toolbox
that referenced
this pull request
Jun 25, 2026
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user. Before merging, please alter the title, message, linkText and linkURL --------- Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 41dfcb7
github-actions Bot
pushed a commit
to pepe57/genai-toolbox
that referenced
this pull request
Jun 25, 2026
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user. Before merging, please alter the title, message, linkText and linkURL --------- Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 41dfcb7
Yuan325
pushed a commit
that referenced
this pull request
Jun 25, 2026
github-actions Bot
pushed a commit
to pepe57/genai-toolbox
that referenced
this pull request
Jun 25, 2026
github-actions Bot
pushed a commit
to rodineyw/mcp-toolbox
that referenced
this pull request
Jun 25, 2026
github-actions Bot
pushed a commit
to Jaleel-zhu/genai-toolbox
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user.
Before merging, please alter the title, message, linkText and linkURL