Skip to content

feat: add dataplex-get-data-product tool#3499

Open
theantagonist9509 wants to merge 27 commits into
googleapis:mainfrom
theantagonist9509:feat/dataplex-get-data-product
Open

feat: add dataplex-get-data-product tool#3499
theantagonist9509 wants to merge 27 commits into
googleapis:mainfrom
theantagonist9509:feat/dataplex-get-data-product

Conversation

@theantagonist9509

@theantagonist9509 theantagonist9509 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Important

Stacked Changeset: This PR depends on changes in previous PRs (#3337).

  • Please merge previous PRs first before reviewing/merging this one.
  • The file diff below will appear large as it includes its ancestors' commits. It will resolve itself once the preceding PRs are merged and this branch is synced.

This PR implements the dataplex-get-data-product tool for the Dataplex
(Knowledge Catalog) source, allowing users to retrieve detailed metadata for
a specific Data Product.

Changes overview:

  • Dataplex Source: Implemented GetDataProduct to fetch a single Data
    Product by location and ID. It maps SDK structures to a clean flat output,
    including display name, description, owner emails, and access groups.
  • New Tool: Created the dataplex-get-data-product tool exposing locationId
    and dataProductId parameters.
  • Tests:
    • Added unit tests for tool configuration parsing.
    • Added integration tests verifying successful retrieval of Data Products
      and proper 401 handling on unauthorized requests.
  • Documentation: Created the reference documentation page for the tool,
    updated the Dataplex source guide, and added the tool details to the
    capabilities list.

theantagonist9509 and others added 24 commits June 2, 2026 14:15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Data Products in the Dataplex (Knowledge Catalog) integration by introducing two new tools: dataplex-list-data-products and dataplex-get-data-product. The changes include updating the Dataplex source to initialize and use the DataProductClient, implementing the new tool configurations, adding comprehensive integration tests, and updating the documentation. The code reviewer provided feedback recommending the consistent capitalization of initialisms like 'ID' (e.g., locationID, dataProductID) to align with Go style guidelines, correcting a typo in a parameter description, explicitly passing the cloud platform scope when finding default credentials in tests, and using t.Fatalf to fail fast during test setup if the service account email is missing.

Comment thread internal/sources/dataplex/dataplex.go Outdated
Comment thread internal/sources/dataplex/dataplex.go Outdated
Comment thread internal/sources/dataplex/dataplex.go Outdated
Comment thread internal/sources/dataplex/dataplex.go
Comment thread internal/sources/dataplex/dataplex.go Outdated
Comment thread internal/tools/dataplex/dataplexgetdataproduct/dataplexgetdataproduct.go Outdated
Comment thread internal/tools/dataplex/dataplexlistdataproducts/dataplexlistdataproducts.go Outdated
Comment thread tests/dataplex/dataplex_integration_test.go
Comment thread tests/dataplex/dataplex_integration_test.go
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants