feat: add dataplex-list-data-assets tool#3500
Open
theantagonist9509 wants to merge 36 commits into
Open
Conversation
…data-products mapping fix
…ke teardowns concurrent
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Dataplex Data Products and Data Assets in the Knowledge Catalog MCP server by adding three new tools: list_data_products, get_data_product, and list_data_assets. The changes include updating the Dataplex source to initialize and use the DataProductClient, implementing the tool configurations and invocation logic, adding integration tests, and updating the documentation. The review feedback suggests exporting the dataProductClient field as DataProductClient in the Source struct for consistency, updating its getter and initialization logic, and correcting a minor typo ('accross') in a parameter description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked Changeset: This PR depends on changes in previous PRs (#3337, #3499).
This PR implements the dataplex-list-data-assets tool for the Dataplex
(Knowledge Catalog) source, enabling users to list and paginate all Data
Assets attached to a specific Data Product.
Changes overview:
to a Data Product parent, supporting custom filtering, page size, and order
parameters.
dataProductId , filter , pageSize , and orderBy parameters.
and proper authorization validation.
Dataplex source guide, and added it to the main capabilities list.