storegateway: fix bucket index discovery logging #14046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Varankin <[email protected]>
jesusvazquez
approved these changes
Jan 15, 2026
narqo
changed the title
alexweav
approved these changes
Jan 15, 2026
mimir-github-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
#### What this PR does Following #13942 The PR fixes the bucket index discovery logging. In the previous one, I've missed that the fields added to the `With` are only applied to the fallback logger. So we don't see these fields in practice 🤦 I've noticed this only now because in one of the cells, where the changes were deployed we do see quite a fair bit of these warnings: <img width="1462" height="225" alt="Screenshot 2026-01-15 at 18 05 53" src="https://github.com/user-attachments/assets/f84144d4-0f67-4b06-a6b0-b15c23ce3ea0" /> #### Which issue(s) this PR fixes or relates to Relates to https://github.com/grafana/mimir-squad/issues/3373 #### Checklist - [ ] Tests updated. - [ ] Documentation added. - [ ] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features. Signed-off-by: Vladimir Varankin <[email protected]> (cherry picked from commit b268f75)
narqo
added a commit
that referenced
this pull request
Jan 16, 2026
Backport b268f75 from #14046 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Fixes logging context in bucket index discovery. > > - In `recordBucketIndexDiscoveryDiff` (bucket.go), use span-aware logger (`spanlogger.FromContext`) as the base for `logger` and call `level.Warn/Debug` directly, removing redundant `spanlogger.FromContext` wrapping. This ensures logs carry the request span context and avoids double-wrapping. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5f979bf. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: Vladimir Varankin <[email protected]> Co-authored-by: Vladimir Varankin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Following #13942
The PR fixes the bucket index discovery logging. In the previous one, I've missed that the fields added to the
Withare only applied to the fallback logger. So we don't see these fields in practice 🤦I've noticed this only now because in one of the cells, where the changes were deployed we do see quite a fair bit of these warnings:
Which issue(s) this PR fixes or relates to
Relates to https://github.com/grafana/mimir-squad/issues/3373
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.