Additional attributes for targeting meta elements #14407
Merged
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederickobrien
force-pushed
the
more-meta-targeting-attributes
branch
from
1886fa9 to
ec4aba5
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
KaliedaRik
approved these changes
Sep 2, 2025
JustinPinner
reviewed
Sep 2, 2025
| @@ -62,7 +66,7 @@ export const Dateline = ({ | |||
| ); | |||
| } | |||
| return ( | |||
| <div css={datelineStyles} style={mobileColour}> | |||
| <div css={datelineStyles} style={mobileColour} data-gu-name="dateline"> | |||
There was a problem hiding this comment.
Just looking out of curiosity so feel free to ignore. Do we ever have to care about primary vs. secondary datelines? Whatever that means 😁
There was a problem hiding this comment.
I was chatting with the Ed Design crew about this earlier and apparently the distinction comes when a piece has been updated. In those cases you have publication date and and last modified date. So I think both pop up.
|
Seen on PROD (merged by @frederickobrien 7 minutes and 58 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following chats with the Editorial Design crew this introduces several new
gu-dataattributes so that interactive atoms can target elements more consistently across web and apps.There's a possibly a larger piece of work to pick up here around keeping web/apps DCAR as tightly aligned as possible, as well as a discussion to be had about formalising the atom contract. What elements/data attributes can we count on always being there?
Still, one thing at a time. Getting this out will allow us to test the waters and make adjustments accordingly.