Skip to content

Additional attributes for targeting meta elements #14407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
+11 −2
Merged

Additional attributes for targeting meta elements #14407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dotcom-rendering/src/components/CommentCount.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export const CommentCount = ({ discussionApiUrl, shortUrlId }: Props) => {
css={containerStyles}
data-testid="comment-counts"
value={`${long} comments on this article`}
data-gu-name="comment-count"
>
<a
href="#comments"
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/components/Contributor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export const Contributor = ({ byline, tags, format, source }: Props) => (
aria-label="Contributor info"
data-component="meta-byline"
data-link-name="byline"
data-gu-name="byline"
>
{format.design !== ArticleDesign.Interview && (
<div
Expand Down
8 changes: 6 additions & 2 deletions dotcom-rendering/src/components/Dateline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ export const Dateline = ({
};
if (secondaryDateline && !secondaryDateline.includes(primaryDateline)) {
return (
<details css={datelineStyles} style={mobileColour}>
<details
css={datelineStyles}
style={mobileColour}
data-gu-name="dateline"
>
<summary css={primaryStyles}>
<span css={hoverUnderline}>{primaryDateline}</span>
</summary>
Expand All @@ -62,7 +66,7 @@ export const Dateline = ({
);
}
return (
<div css={datelineStyles} style={mobileColour}>
<div css={datelineStyles} style={mobileColour} data-gu-name="dateline">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looking out of curiosity so feel free to ignore. Do we ever have to care about primary vs. secondary datelines? Whatever that means 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was chatting with the Ed Design crew about this earlier and apparently the distinction comes when a piece has been updated. In those cases you have publication date and and last modified date. So I think both pop up.

{primaryDateline}
</div>
);
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/components/FollowWrapper.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ export const FollowWrapper = ({ id, displayName }: Props) => {
}
}
`}
data-gu-name="follow"
>
{showFollowTagButton && (
<FollowTagButton
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/components/LiveblogNotifications.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export const LiveblogNotifications = ({ id, displayName }: Props) => {
}
}
`}
data-gu-name="liveblog-notifications"
>
<FollowNotificationsButton
isFollowing={isFollowingNotifications ?? false}
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/components/ShareButton.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export const CopyNativeShareButton = ({
sharedButtonStyles(sizeXSmall),
isLiveBlogMeta && liveBlogMobileMeta(isCopied),
])}
data-gu-name="share-button"
>
{isCopied ? 'Link copied' : 'Share'}
</Button>
Expand Down
Loading