Fix testrun detachment #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pavse The changes you made looks good. Can you point this PR merge to release/1.12.0? Thank you. |
|
hi @acuanico-tr-galt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being resolved: #340
Solution description
Improve handling of field
milestone_idin the request bodyChanges
Add
milestone_idto the body only if it is not None, instead of always including itPotential impacts
Should be none
Steps to test
pytest -v -p no:warnings -k test_post_run tests/test_api_data_provider.py::TestApiDataProvider::test_post_run PASSED [ 50%] tests/test_api_data_provider.py::TestApiDataProvider::test_post_run_all_args PASSED [100%] =================== 2 passed, 215 deselected in 1.02s ===================PR Tasks
added/updated