Skip to content

Fix testrun detachment #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

Fix testrun detachment #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe756a6
Fix milestone_id handling in API data provider; fixes #340
pavse Aug 17, 2025
3510b75
Remove milestone_id from test run data providers
pavse Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tests/test_data/api_data_provider_test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,14 @@
"description": "logging: True\ndebug: False",
"name": "test run",
"suite_id": 123,
"case_ids": [60, 4],
"milestone_id": None
"case_ids": [60, 4]
}

post_run_full_body = {
"description": "logging: True\ndebug: False",
"name": "test run",
"suite_id": 123,
"case_ids": [60, 4],
"milestone_id": None,
"assignedto_id": 1,
"include_all": True,
"refs": "SAN-1, SAN-2"
Expand Down
3 changes: 2 additions & 1 deletion trcli/data_providers/api_data_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ def add_run(
body = {
"suite_id": self.suites_input.suite_id,
"description": "\n".join(properties),
"milestone_id": milestone_id,
"case_ids": case_ids
}
if isinstance(start_date, list) and start_date is not None:
Expand All @@ -116,6 +115,8 @@ def add_run(
body["refs"] = refs
if run_name is not None:
body["name"] = run_name
if milestone_id is not None:
body["milestone_id"] = milestone_id
return body

def add_results_for_cases(self, bulk_size):
Expand Down
Loading