Repository navigation
capi: add HarfBuzz C++ ownership helpers for core objects - #544
Merged
Merged
Conversation
This was referenced Oct 16, 2026
dfrg
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
hr-hb-cplusplus.hhas a replacement for HarfBuzz'shb-cplusplus.hh, retaining the ownership helpers, traits, hash specializations, and upstream license. The helpers cover blobs, buffers, faces, fonts, font functions, maps, sets, and shape plans. Forwarding adapters preserve HarfBuzz's user-data signatures while accommodating HarfRust's const keys and mixed getter signatures.This PR builds on
mainwith published dependencies. Subset input and plan ownership helpers are added by #547 together with their metadata APIs. The C++ consumer checks both subset header include orders using the released subset API, plus core-only linking without subsetting enabled.Validation: GCC and Clang C++11/C++17 consumers exercise copying, moves, unique release/swap, hashes, empty objects, and exactly-once user-data destruction. The Rust suite, formatting, Clippy, generated-header checks, and default/subset builds pass.
Merge order: #544 → #545 → #546 → #519 → #547. Only #547 waits for a Skera release.
Replaces #514; the earlier PR retains its review history.