Repository navigation
Conversation
This was referenced Oct 16, 2026
behdad
changed the base branch from
capi/released-skia-runtime
to
capi/skrifa-draw-paint
October 16, 2026 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires a Skera release containing the public Plan APIs from googlefonts/fontations#2234 . Keep this PR in draft until that release is available and replace the temporary Skera/write-fonts Git pins before merging.
Add HarfBuzz-compatible subset plan creation/reference/destruction/execution, original-to-subset and reverse glyph maps, Unicode-to-original maps, and user data on inputs and plans. Plans snapshot source tables and input settings, support repeated/concurrent execution, and return borrowed core
hr_map_thandles that may be retained independently. Metadata replacement/destruction invokes release callbacks outside the lock for reentrancy. Custom no-subset-table selections pass through unchanged, with explicit drops and hint removal taking precedence.Extend
hr-hb-cplusplus.hhwith subset input and plan ownership helpers, including both header include orders. Extend Linux CI with the 16 plan/map comparisons, bringing the total to 79, and exercise plan execution/mapping queries in the C example.These APIs are part of the optional
subsetfeature ofharfrust_capi; enable it withcargo build -p harfrust_capi --features subsetand link the singleharfrust_clibrary. Headers, examples, and tests live underharfrust_capi.Validation: all 79 differential subset cases pass, including plan snapshots, mappings, concurrent execution, retained map lifetimes, metadata rejection/replacement/reentry/destruction, and table passthrough/drop precedence. GCC/Clang C99 shared/static and C++11/C++17 ownership consumers pass. Generated headers remain synchronized.
Stacked on #519. Merge order: #544 → #545 → #546 → #519 → #547. The first four PRs use published dependencies and can merge while this PR waits for Skera. Axis instancing, user-specified glyph mapping, and CFF/CFF2/VARC support remain separate work.
Replaces #513; the earlier PR retains its review history.