Cleanup around subprocess helpers #7995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
- Set enable_process_jobs on a variant of System.Process.proc
instead of just for System.Process.createProcess
- In Distribution.Simple.Utils, only use this proc instance.
- Replace use of printRawCommand* by a unified helper logCommand,
and use this more consistently. The output format is changed
slightly.
- New helpers rawSystemProc{,Action} for use with new proc
Aside from the logging changes, this should be a no-op.
robx
force-pushed
the
cleanup-processes
branch
from
dfc0913 to
cc8a7af
Compare
robx
force-pushed
the
cleanup-processes
branch
from
cc8a7af to
91fa33b
Compare
robx
changed the title
|
Alright, fingers crossed this should be ready for review now. The commits are also in a reasonable state now. |
Mikolaj
approved these changes
Feb 23, 2022
|
CI jobs are stuck due to #8000 not merged yet, so let me merge manually. BTW. I forgot to rebase this one and caused git commit diagram art. Sorry about that. |
Mikolaj
added a commit
to Mikolaj/cabal
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be a mostly-no-op change to provide a basis for a clean take of #7921. The guiding principle was to reduce the number of
createProcesscalls and collect them inDistribution.Simple.Utils.Functional changes should be limited to:
delegate_ctlcandenable_process_jobs)One of the last commits removes some obsolete functions that I'd previously deprecated. I'm a bit unsure if we need to deprecate these mostly-internal functions.
All those
rawSystemhelpers still feel a bit messy and I'm sure there's more that could be done, but I think this should already be a step forward, and will allow switching to some kind of bracketedwithProcessin the context of #7921 much easier, and hence easier to review.Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!