Revert "Merge pull request #7995 from robx/cleanup-processes"

[jneira]

This reverts commit ddf3ba2, reversing
changes made to 001e3cc.

pr #7995

I've checked manually a version of branch 3.8 with this reverted and it does not show the problem described here: #8208
This is the fast way to remove the issue for the incoming 3.8 version but ideally the pr should be kept and fixed as the refactor was good.

//cc @robx

[hasufell]

Why are we reverting? Is there time pressure? The correct way is to fix it.

Please explain exactly what this reversal fixes, on which platform etc. Even after reading #8208 I don't understand it.

[jneira]

The bug and the platform is the title of the linked issue: Interrupting cabal-3.8.0.0.20220526 with ctrl+c makes it hang on windows. Not sure how could be more precise or clearer about that.

The time pressure is mentioned in the last comment of the issue, and also my preference for fixing it.

i would like to examine the pr and find the cause to not having to revert it but i will not have time to not delay the release excessively, what do you think about?

[hasufell]

-1 for reverting, unless @robx agrees that fixing will take a long time. The way is forward. Releases should be good quality.

[jneira]

-1 for reverting, unless @robx agrees that fixing will take a long time. The way is forward. Releases should be good quality.

Agree, i asked @robx (and include it as reviewer) for that reason. I would not merge this without his approval.
This one would be the last resort to not include the bug in the release. Will mark as draft to make it clearer.

[Mikolaj]

For the record, the PR being reverted is #7995. If I understand correctly, this reverts a merge commit, which causes the whole PR to be left out. Let me restart CI to verify if the failure is transient.