-
Notifications
You must be signed in to change notification settings - Fork 3
Tablet and Phone Interface Improvements #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…eleop into feature/mobile
…ch_web_teleop into feature/mobile
@kaikwan @hello-william @mintyfreshv click to pregrasp has been fixed on mobile and desktop. I tested it on 3030 and verified it works as expected when using a chrome browser on a desktop and an IPad |
@hello-william The panel resizing is not working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's goooooooooo ☄️
@mintyfreshv red means the joint limit was reach, the button highlights blue/green when that joint is moving. |
All tests passed on
|
ScreenRecording_05-29-2025.15-23-13_1.movCannot delete previously, saved “movement recordings” Devices where this issue occurs: iPad and desktop version |
ScreenRecording_05-29-2025.15-32-42_1.movPart of the customization menu is showing when I slide the interface to the left. Please see video for demonstration. This is on the iPad |
Inquiry about joystick control input on the mobile tablet version of the interface https://github.com/user-attachments/assets/cef28f8e-9923-4249-a8fa-499ac12d78e5 This is on the iPad |
Video 1 Video 1 follow up Issue: recording new movement recordings do not work when initiated Devices where issues occur: iPad and desktop version Video description: I am limited to about six seconds of video footage. I can send over GitHub. So I split up the videos and edit it down quite a bit. Essentially, I’m giving you an example of recording the robot’s arm fully extended. I’ve labeled it “arm out,” and you will see a video too, that when I click “arm out,” Stretch doesn’t do anything. However, I had already shave, pre-existing movement recordings before testing today, and those still work. The new ones I created today don’t work though. Also, it may not seem clear in the videos, but I did save the recording, as you see in the drop-down the label “arm out” is present. |
To Do List based on @mintyfreshv's feedback:
|
Description
This PR makes a series of changes to improve the tablet and phone view for the interface made in the
temp/deployment
branch. The tablet view should appear as a scaled down view from the desktop version and the mobile interface has a different layout to make the best use of space.Currently there are some known issues that need be resolved:
Testing procedure
Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-files
To merge
Squash & Merge