Skip to content

Tablet and Phone Interface Improvements #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

hello-vinitha
Copy link
Collaborator

@hello-vinitha hello-vinitha commented May 13, 2025

Description

This PR makes a series of changes to improve the tablet and phone view for the interface made in the temp/deployment branch. The tablet view should appear as a scaled down view from the desktop version and the mobile interface has a different layout to make the best use of space.

Currently there are some known issues that need be resolved:

  • In the tablet customization mode some components disappear when another component is added or a component is moved.
  • Button pad buttons sometimes overflow out of the panel depending on the size of the screen.

Testing procedure

  • Test that components can be successfully added, removed and rearranged (desktop, tablet)
  • Verify mobile responsiveness on different screen sizes (tablet & mobile)
  • Verify the correct buttons are being highlighted blue/green when the joint is moving
  • Verify the correct buttons are highlighted red when the respective joint is at it's limit
  • Verify click-to-pregrasp works on (desktop & tablet)
  • Verify that cameras and buttons are sized appropriately for the screen (i.e. buttons/camera are not overflowing or too small, etc.)
  • Verify that all action modes work across desktop and mobile

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

@mintyfreshv
Copy link

IMG_0107

Referring to the button pad, the colors for notifying the person that they’re at their joint limit is variable. Is there a reason why it’s red and green?

@mintyfreshv
Copy link

IMG_0108

In this photo, you can see that lifting the arm button is highlighted green, but I am not using that button at the moment because at the time of this photo I was using, the lowering the arm button

@hello-vinitha
Copy link
Collaborator Author

@kaikwan @hello-william @mintyfreshv click to pregrasp has been fixed on mobile and desktop. I tested it on 3030 and verified it works as expected when using a chrome browser on a desktop and an IPad

@hello-vinitha
Copy link
Collaborator Author

@hello-william The panel resizing is not working as expected.
https://github.com/user-attachments/assets/9fcbecbf-981b-49e6-a292-b581052a1d02

Copy link
Collaborator

@hello-william hello-william left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's goooooooooo ☄️

@hello-vinitha
Copy link
Collaborator Author

IMG_0107

Referring to the button pad, the colors for notifying the person that they’re at their joint limit is variable. Is there a reason why it’s red and green?

@mintyfreshv red means the joint limit was reach, the button highlights blue/green when that joint is moving.

@hello-vinitha
Copy link
Collaborator Author

hello-vinitha commented May 29, 2025

All tests passed on 3030. @mintyfreshv please test on your robot.

  • Test that components can be successfully added, removed and rearranged (desktop, tablet)
  • Verify mobile responsiveness on different screen sizes (tablet & mobile)
  • Verify the correct buttons are being highlighted blue/green when the joint is moving
  • Verify the correct buttons are highlighted red when the respective joint is at it's limit
  • Verify click-to-pregrasp works on (desktop & tablet)
  • Verify that cameras and buttons are sized appropriately for the screen (i.e. buttons/camera are not overflowing or too small, etc.)

@mintyfreshv
Copy link

mintyfreshv commented May 29, 2025

ScreenRecording_05-29-2025.15-23-13_1.mov

Cannot delete previously, saved “movement recordings”

Devices where this issue occurs: iPad and desktop version

@mintyfreshv
Copy link

mintyfreshv commented May 29, 2025

ScreenRecording_05-29-2025.15-32-42_1.mov

Part of the customization menu is showing when I slide the interface to the left. Please see video for demonstration.

This is on the iPad

@mintyfreshv
Copy link

mintyfreshv commented May 29, 2025

Inquiry about joystick control input on the mobile tablet version of the interface

https://github.com/user-attachments/assets/cef28f8e-9923-4249-a8fa-499ac12d78e5
I am forgetting, and likely need a recall regarding the functionality of the joystick option on the tablet. Is it meant to be limited in use when it’s on the tablet? Something tells me that this is the case, but I am not sure again.

This is on the iPad

@mintyfreshv
Copy link

mintyfreshv commented May 29, 2025

IMG_0118

Issue: wide angle head camera bottom arrow are not in the camera feed

This is on the iPad

@mintyfreshv
Copy link

mintyfreshv commented May 29, 2025

Video 1
https://github.com/user-attachments/assets/966c541b-c0e2-4793-b0ad-55faff82a34f

Video 1 follow up
https://github.com/user-attachments/assets/a87e552d-ae3a-43c9-bf3b-6e68a58e3564

Issue: recording new movement recordings do not work when initiated

Devices where issues occur: iPad and desktop version

Video description: I am limited to about six seconds of video footage. I can send over GitHub. So I split up the videos and edit it down quite a bit. Essentially, I’m giving you an example of recording the robot’s arm fully extended. I’ve labeled it “arm out,” and you will see a video too, that when I click “arm out,” Stretch doesn’t do anything.

However, I had already shave, pre-existing movement recordings before testing today, and those still work. The new ones I created today don’t work though. Also, it may not seem clear in the videos, but I did save the recording, as you see in the drop-down the label “arm out” is present.

@mintyfreshv
Copy link

mintyfreshv commented May 29, 2025

IMG_0123

Issue: move to pre-grasp

Description: move to pre-grasp worked for me once, but it was about three or 4 inches away from my target. After trying it again, the feature kept failing. Perhaps, this is what Will has been also facing?

This is on the iPad

@mintyfreshv
Copy link

IMG_2443
Device: phone interface

Issue: the play button and the controls under recordings. Please see screen capture.

@hello-vinitha
Copy link
Collaborator Author

hello-vinitha commented May 30, 2025

To Do List based on @mintyfreshv's feedback:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants